BHoM Tkinter bug fixes and improvements#214
Open
Felix-Mallinder wants to merge 12 commits into
Open
Conversation
…tring identifiers
wired previous unique methods in base class one to ensure backwards compatibility
Open
Contributor
Author
|
@BHoMBot check required |
|
@Felix-Mallinder to confirm, the following actions are now queued:
|
Tom-Kingstone
requested changes
May 11, 2026
Contributor
Tom-Kingstone
left a comment
Tom-Kingstone
left a comment
There was a problem hiding this comment.
Initial review from cursory speed read, some things I noticed that I think need changing.
Contributor
|
@BHoMBot check installer |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
|
The check |
applying suggestion mainly to trigger bot check. Most likely the try/except block is going to be removed entirely
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Tom-Kingstone
requested changes
May 13, 2026
Contributor
Tom-Kingstone
left a comment
Tom-Kingstone
left a comment
There was a problem hiding this comment.
More changes and queries
Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
Contributor
|
@BHoMBot check installer |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #213 , #215
General upgrade to the BHoM Tkinter tools, prompted by bugs in aesthetic and functionality issues identified in dependant toolkit(s).
Overview:
on_changecallback implemented at toplevel, inbhom_base_widget, for consistent action of widgets in a formTest files
~\Python_Toolkit\Python_Engine\Python\testsChangelog
Additional comments