Skip to content

Signature Validation: Remove exceptions - #2757

Merged
Ignacio Inglese (iNinja) merged 7 commits into
devfrom
iinglese/validate-signature
Aug 6, 2024
Merged

Signature Validation: Remove exceptions#2757
Ignacio Inglese (iNinja) merged 7 commits into
devfrom
iinglese/validate-signature

Conversation

@iNinja

Copy link
Copy Markdown
Contributor

Signature Validation: Remove exceptions

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Part of the ValidateJWS/JWEAsync, removed exception throwing from signature validation. Refactored code and simplified some paths along the way.

@iNinja
Ignacio Inglese (iNinja) requested a review from a team as a code owner July 31, 2024 17:10
Comment thread src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Outdated

@jennyf19 jennyf19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants