[iOS] Block external roles from activating UIScene - #21844
Merged
Conversation
MrJul
added
bug
os-ios
backport-candidate-12.1.x
MrJul
enabled auto-merge
July 24, 2026 10:35
|
You can test this PR using the following package version. |
Contributor
|
Thanks for the insanely fast turn-around on this! I'm trying to test at the moment, but having trouble with my dev machine: shall report back as soon as possible... |
Contributor
|
Can confirm the issue we were seeing is fixed with 12.2.999-cibuild0067683-alpha Thanks again for addressing this so quickly |
MrJul
pushed a commit
that referenced
this pull request
Jul 29, 2026
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21832
This PR updates the scene connection logic in
AvaloniaSceneDelegateto better protect against non-application scenes. When you screen mirror, the UIScene would be invoked with roles that would end up stealing views. Long-term, we need to refactor how scene delegates work with UIKit, but for now, to keep everything working and consistent, we only support the Application instance and ignore the others. That will allow stuff like AirPlay to work.Copilot stuff below:
Scene connection safety:
Applicationrole are handled, preventing unintended handling of system-created scenes (e.g., for external displays or CarPlay) in theWillConnectmethod ofAvaloniaSceneDelegate(Avalonia.iOS/AvaloniaSceneDelegate.cs).