Position popup using the screen containing the anchor point - #21750
Merged
Conversation
MrJul
added
bug
backport-candidate-12.1.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jul 11, 2026
MrJul
added a commit
that referenced
this pull request
Jul 29, 2026
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures that popups are positioned on the screen containing their anchor point by default.
Before this PR, the screen containing the top-left point of the anchor rect was always used, resulting in unexpected placements (see #15261).
This PR only changes the default position before gravity or constraints are applied.
Unit tests have been added.
(Apparently, we didn't have any unit tests for
ManagedPopupPositionerbefore, so we might as well start now.)Fixed issues
Fixes #15261