Fix AndroidStorage.TryGetFile/FolderFromPathAsync returning null or throwing - #21628
Merged
Merged
Conversation
MrJul
added
bug
os-android
backport-candidate-12.0.x
3 tasks
|
You can test this PR using the following package version. |
emmauss
approved these changes
Jun 22, 2026
MrJul
added this pull request to the merge queue
Jun 22, 2026
MrJul
added a commit
to MrJul/Avalonia
that referenced
this pull request
Jun 23, 2026
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes
AndroidStorage.TryGetFileFromPathAsyncandTryGetFolderFromPathAsyncnot returning results for several reasons.First, the
READ_EXTERNAL_STORAGEpermission is always denied since Android API 33, which means the call always failed on such platforms. This PR no longer checks for that permission, as it might not be required at all (e.g., files in the app's folder since API 19, well below our minimum supported level, 24) or might always be denied (API ≥ 33). This is a bit similar to what #18637 was doing.Second, some code logic was inverted, meaning that existing files and folders would always return
null.Notes
On Android, the objects we return from
TryGetFileFromPathAsync,TryGetFolderFromPathAsyncandTryGetWellKnownFolderAsyncare pretty useless. See #21629.