Handle replacementRange in AvnView - #21608
Merged
Merged
Conversation
MrJul
added
bug
os-macos
backport-candidate-12.0.x
3 tasks
MrJul
added
the
customer-priority
|
You can test this PR using the following package version. |
MrJul
added
the
backport-candidate-11.3.x
MrJul
added this pull request to the merge queue
Jun 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 19, 2026
MrJul
added this pull request to the merge queue
Jun 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 20, 2026
MrJul
added this pull request to the merge queue
Jun 21, 2026
MrJul
added a commit
that referenced
this pull request
Jun 23, 2026
* macOS: ensure native selectedRange is up-to-date * macOS: handle replacementRange in setMarkedText and insertText * macOS: handle unexpected ranges in attributedSubstringForProposedRange
MrJul
added
backported-11.3.x
and removed
backport-candidate-11.3.x
MrJul
added a commit
to MrJul/Avalonia
that referenced
this pull request
Jun 23, 2026
* macOS: ensure native selectedRange is up-to-date * macOS: handle replacementRange in setMarkedText and insertText * macOS: handle unexpected ranges in attributedSubstringForProposedRange
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
github-actions Bot
pushed a commit
to Stella-sea/ryujinx-admin
that referenced
this pull request
Jun 26, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [Avalonia](https://avaloniaui.net/?utm_source=nuget&utm_medium=referral&utm_content=project_homepage_link) ([source](https://github.com/AvaloniaUI/Avalonia)) | `11.3.17` → `11.3.18` |  |  | | [Avalonia.Desktop](https://avaloniaui.net/?utm_source=nuget&utm_medium=referral&utm_content=project_homepage_link) ([source](https://github.com/AvaloniaUI/Avalonia)) | `11.3.17` → `11.3.18` |  |  | | [Avalonia.Diagnostics](https://avaloniaui.net/?utm_source=nuget&utm_medium=referral&utm_content=project_homepage_link) ([source](https://github.com/AvaloniaUI/Avalonia)) | `11.3.17` → `11.3.18` |  |  | | [Avalonia.Markup.Xaml.Loader](https://avaloniaui.net/?utm_source=nuget&utm_medium=referral&utm_content=project_homepage_link) ([source](https://github.com/AvaloniaUI/Avalonia)) | `11.3.17` → `11.3.18` |  |  | --- ### Release Notes <details> <summary>AvaloniaUI/Avalonia (Avalonia)</summary> ### [`v11.3.18`](https://github.com/AvaloniaUI/Avalonia/releases/tag/11.3.18) [Compare Source](AvaloniaUI/Avalonia@11.3.17...11.3.18) ##### What's Changed ##### Enhancements - XAML – Enhance Roslyn-compiler visible metadata by [@​maxkatz6](https://github.com/maxkatz6) in [#​21546](AvaloniaUI/Avalonia#21546) ##### Fixes - Core – Fix StackOverflow when a `NaN` offset is set on `ScrollViewer` by [@​NicholasLachapelle](https://github.com/NicholasLachapelle) in [#​21558](AvaloniaUI/Avalonia#21558) - macOS – Handle `replacementRange` in `AvnView` by [@​MrJul](https://github.com/MrJul) in [#​21608](AvaloniaUI/Avalonia#21608) **Full Changelog**: <AvaloniaUI/Avalonia@11.3.17...11.3.18> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzguMCIsInVwZGF0ZWRJblZlciI6IjQzLjE3OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR started as an investigation into a problem that remained in #21569.
It uncovered several issues, now fixed:
replacementRangeto lag behind, in bothsetMarkedTextandinsertText.replacementRangewasn't handled insetMarkedText, causing duplicate characters.replacementRangewasn't handled ininsertText, causing duplicate characters. This is what fix duplicates in MacOS special character inputs #21569 did, but we now don't need any special casing sincereplacementRangeis correct.attributedSubstringForProposedRange, triggering an assertion failure (visible in debug mode).The "accent menu" (visible by holding a key) now works properly.
IMEs have been re-tested.