Skip to content

AT-SPI: SelectChild should add to the selection instead of replacing it - #21602

Merged
MrJul merged 1 commit into
masterfrom
fix/atspi-additive-selection
Jun 17, 2026
Merged

AT-SPI: SelectChild should add to the selection instead of replacing it#21602
MrJul merged 1 commit into
masterfrom
fix/atspi-additive-selection

Conversation

@jmacato

@jmacato jmacato commented Jun 17, 2026

Copy link
Copy Markdown
Member

AtSpiSelectionHandler.SelectChild called ISelectionItemProvider.Select(), which
replaces the selection, so additive multi-select was impossible over AT-SPI.
Switch to AddToSelection(): additive for multi-select containers, and still
replacing on single-select models. Matches the AT-SPI spec and the UIA backend.

@MrJul MrJul added os-linux area-accessibility backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch labels Jun 17, 2026

@MrJul MrJul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrJul
MrJul enabled auto-merge June 17, 2026 08:12
@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0066573-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added the bug label Jun 17, 2026
@MrJul
MrJul added this pull request to the merge queue Jun 17, 2026
Merged via the queue into master with commit b164b25 Jun 17, 2026
11 checks passed
@MrJul
MrJul deleted the fix/atspi-additive-selection branch June 17, 2026 11:15
MrJul pushed a commit to MrJul/Avalonia that referenced this pull request Jun 23, 2026
@MrJul MrJul added backported-12.0.x and removed backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants