Better platform window handle abstraction for DBusSystemDialog - #21379
Merged
Conversation
MrJul
reviewed
May 18, 2026
| /// underlying platform state has changed (e.g. wayland compositor reconnect) and | ||
| /// previously-selected providers may no longer be appropriate. | ||
| /// </summary> | ||
| public void Reset(Func<Task<IStorageProvider?>>[] factories) |
Member
There was a problem hiding this comment.
This method will be called by Wayland in a subsequent PR I assume.
MrJul
enabled auto-merge
May 18, 2026 09:21
MrJul
added this pull request to the merge queue
May 18, 2026
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to reuse DBus dialog for Wayland. Unhardcodes "x11:" prefix, introduces window handle lifetime management (i. e. DBus dialog needs to tell when it's done.