Add min php and wp notice - #80
Merged
Merged
Conversation
sanmai
approved these changes
Sep 16, 2024
alecgeatches
approved these changes
Sep 17, 2024
alecgeatches
left a comment
alecgeatches
left a comment
Contributor
There was a problem hiding this comment.
Changes look good to me, but I'm not sure that we need to bump the version and do a release for this PR alone. What about leaving it at 1.4.1, and then this will get merged when we do a next release?
Contributor
Author
Agreed on that, works for me tbh |
alecgeatches
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I realized we don't have a PHP and WP version check and the one we have been relying won't really be enforced for the way we expect this plugin to be deployed. So I have added in a manual check, akin to what we have in the workflow plugin.
This is already what the plugin supports so it's just matching that.
Steps to Test
Either load a WP version prior to 6.0 with PHP version lower than 8.0, or change those numbers to something arbitrary and see it fail.