fix: await post.populate() in test to prevent dangling promise on Node 18 - #16366
Merged
vkarpov15 merged 2 commits intoJul 20, 2026
Merged
Conversation
…x flaky test on Node 18
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Node 18 MongoDB 7.0.7
fix: await post.populate() in test to prevent dangling promise on Node 18
Jul 6, 2026
vkarpov15
marked this pull request as ready for review
July 20, 2026 14:49
vkarpov15
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI job "Node 18 MongoDB 7.0.7 OS ubuntu-22.04" on the
7.xbranch fails with a 2000ms timeout in thebeforeEachhook for the "using multiple populate calls" test. Two bugs in7.x'stest/util.jsare the primary root causes (both already fixed onmasterviaf40ce4555):clearTestData— missingreturnafter the first successfuldropDatabase()causes the DB to be dropped up to 5× per test. By the 4th test, 15+ sequential drops cause MongoDB 7.0.7 to respond slowly enough that the nextUser.create()exceeds the Mocha timeout.stopRemainingOps— setsbuffer=trueon collections but doesn't remove them fromdb.collectionscache, so freshly registered models in the nextbeforeEachmay inherit a buffered collection.Changes
test/document.populate.test.js: Addawaitto the previously fire-and-forgetpost.populate(param)call in "using multiple populate calls". Withoutawait, a dangling Promise is left in-flight whenclearTestDatadrops the DB, which can produce an unhandled rejection and leaves a permanently buffered operation stuck in the collection queue.