Preserve the original exception when another one happens during rollback - #126
Merged
Conversation
lbialy
approved these changes
Jul 30, 2025
lbialy
left a comment
lbialy
left a comment
Contributor
There was a problem hiding this comment.
this is quite important for anything that attempts to use exceptions as an error handling mechanism, especially given that we have boundary/break in stdlib
Owner
|
Apologies for the delay @adamw ; will look at this today |
Owner
|
LGTM, thanks @adamw |
Owner
|
Let me know if you'd like me to backport to 1.x |
Contributor
Author
|
@AugustNagro if I were able to choose, I would vote for a 2.0 final release ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.