Drop stale purges so rescanAll doesn't undo re-deliveries#17
Merged
Conversation
After a re-delivery republishes a previously-deleted release, the S3 poller's rescanAll re-parses the original PurgeReleaseMessage and markForDelete flips status back to DeletePending — wiping the fresh publish on the next worker tick. Mirror upsert's staleness guard: ignore a purge whose messageTimestamp is not newer than the row's current messageTimestamp. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletedbecause the S3 poller's rescanAll re-parsed the originalPurgeReleaseMessage, andmarkForDeletehad no staleness guard.publishReleasesucceeded with a freshtrackId, then a stale purge re-fireddeleteTrackagainst it.messageTimestampis not newer than the row's currentmessageTimestamp— same shape as the upsert path's existing staleness check.Test plan
tsc --noEmitpassesparseTakedown.test.tsupdated: re-loading the same purge XML now correctly no-ops instead of round-tripping throughDeletePending.Publishedrow with a futuremessageTimestampstaysPublishedwhen an olderPurgeReleaseMessageis re-parsed.make test— please run before merging (couldn't run locally, no disk for the test postgres)🤖 Generated with Claude Code