Skip to content

Remove all references to '/dev/*' in test framework.#751

Merged
drroe merged 2 commits into
Amber-MD:masterfrom
drroe:fixTestDev
Sep 10, 2019
Merged

Remove all references to '/dev/*' in test framework.#751
drroe merged 2 commits into
Amber-MD:masterfrom
drroe:fixTestDev

Conversation

@drroe

@drroe drroe commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Related to #750 and some of the changes in #747. File redirection in scripts should now be properly handled everywhere.

@drroe drroe added the Tests label Sep 10, 2019
@drroe drroe self-assigned this Sep 10, 2019
@drroe

drroe commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

I don't get PGI compilers. Last Jenkins run (91) passed, now this one (92) fails. It's very arbitrary and I'm really inclined to just ignore it.

@drroe drroe merged commit 41e1342 into Amber-MD:master Sep 10, 2019
@drroe drroe deleted the fixTestDev branch September 10, 2019 13:35
@swails

swails commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

If we're going to ignore the PGI fileaures (which I totally support), then we should remove that stage from the Jenkinsfile.

Keep in mind that Jenkins also is responsible for detecting pytraj breaks, but it only does that if all of the individual stages succeed. So each time PGI fails and we ignore it, pytraj build/tests never get run with the proposed changes.

@drroe

drroe commented Sep 10, 2019

Copy link
Copy Markdown
Contributor Author

If we're going to ignore the PGI fileaures (which I totally support), then we should remove that stage from the Jenkinsfile.

Long term I agree. I'd like to keep it for now to see if the failures really are random. If over the next few PR I get sometimes passing, sometimes failing I'll consider it too much of a pain to debug and disable it. However, if it's failing consistently I'd like to address that.

@swails

swails commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Well at least we shouldn't block the pytraj tests from proceeding if the PGI builds fail.

@sbrozell

Copy link
Copy Markdown

Keep me, @sbrozell , in the loop.
For context see
https://gitlab.ambermd.org/amber/amber/merge_requests/319

@sbrozell

Copy link
Copy Markdown

@drroe please include me in your repo; not sure what i need to do ... thanks

@hainm

hainm commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants