Skip to content

Changed verification of Title with tests - #432

Merged
DimitrySteenkamer merged 2 commits into
masterfrom
feature/O2B-425
Nov 12, 2021
Merged

Changed verification of Title with tests#432
DimitrySteenkamer merged 2 commits into
masterfrom
feature/O2B-425

Conversation

@jikkert

@jikkert jikkert commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

feature(Log creation): Changed validation on log creation.

Replies do not need a title anymore. If there is a title it has the normal validation.

@codecov

codecov Bot commented Nov 4, 2021

Copy link
Copy Markdown

Codecov Report

Merging #432 (3eaccf5) into master (fe138c1) will increase coverage by 1.69%.
The diff coverage is 100.00%.

❗ Current head 3eaccf5 differs from pull request most recent head 4d383ee. Consider uploading reports for the commit 4d383ee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   91.45%   93.14%   +1.69%     
==========================================
  Files         226      213      -13     
  Lines        9315     8171    -1144     
  Branches      671      569     -102     
==========================================
- Hits         8519     7611     -908     
+ Misses        796      560     -236     
Impacted Files Coverage Δ
lib/public/views/Logs/Create/index.js 99.31% <100.00%> (+7.53%) ⬆️
lib/public/components/Filters/RunsFilter/index.js 72.91% <0.00%> (-22.54%) ⬇️
lib/public/views/Runs/ActiveColumns/index.js 93.90% <0.00%> (-0.84%) ⬇️
lib/public/Model.js 95.85% <0.00%> (-0.02%) ⬇️
lib/public/view.js 100.00% <0.00%> (ø)
lib/public/components/Filters/RunsFilter/dcs.js
lib/public/components/Filters/RunsFilter/epn.js
lib/public/components/Filters/RunsFilter/nFlps.js
...public/components/Filters/RunsFilter/nDetectors.js
...ublic/components/Filters/RunsFilter/epnTopology.js
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f24d4...4d383ee. Read the comment docs.

@DimitrySteenkamer
DimitrySteenkamer merged commit 32bcc6d into master Nov 12, 2021
@DimitrySteenkamer
DimitrySteenkamer deleted the feature/O2B-425 branch November 12, 2021 09:32
@DimitrySteenkamer
DimitrySteenkamer restored the feature/O2B-425 branch November 12, 2021 09:33
@graduta
graduta deleted the feature/O2B-425 branch June 14, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants