[O2B-1577] Rename include.byName filter to permittedNonPhysicsNames#2128
Open
NarrowsProjects wants to merge 4 commits into
Conversation
NarrowsProjects
added
backend
javascript
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
==========================================
- Coverage 45.88% 45.71% -0.17%
==========================================
Files 1035 1035
Lines 17167 17165 -2
Branches 3124 3123 -1
==========================================
- Hits 7877 7847 -30
- Misses 9290 9318 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NarrowsProjects
force-pushed
the
improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName
branch
from
893ed68 to
18fb34c
Compare
graduta
requested changes
May 26, 2026
| * @property {number[]} [filter.simulationPassIds] simulationPass identifier to filter with | ||
| * @property {number[]} [filter.ids] data passes identifier to filter with | ||
| * @property {string[]} [filter.names] data passes names to filter with | ||
| * @property {boolean} [filter.includeByName] list of tokens in data passes names which indicate |
Member
There was a problem hiding this comment.
I believe this doc should be updated as well, both its type and name
Collaborator
Author
There was a problem hiding this comment.
Thanks, I missed that one
| return helper.error('byName cannot have more than 10 characters'); | ||
| } | ||
| const nameTokens = value?.split(','); | ||
| // 'debug,test' or the reverse have a length of 10 |
Member
There was a problem hiding this comment.
What if instead of the hardcoded value 10, we use the length of the array + commas?
So that in the future, if it increases we are covered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: