Skip to content

feat: Add Page Etag Generator - #3738

Merged
tvdeyen merged 1 commit into
mainfrom
page-etag-generator
Mar 12, 2026
Merged

tvdeyen merged 1 commit into
mainfrom
page-etag-generator

Conversation

@tvdeyen

@tvdeyen tvdeyen commented Mar 11, 2026

Copy link
Copy Markdown
Member

What is this pull request for?

A class responsible for generating the etag for a page. Takes time based element publication into account as before, but take additional arguments and is callable from outside of the pages controller.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 8.2 milestone Mar 11, 2026
@tvdeyen
tvdeyen requested a review from a team as a code owner March 11, 2026 16:59
@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (0908f40) to head (20ed84d).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3738   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         315      316    +1     
  Lines        8354     8361    +7     
=======================================
+ Hits         8144     8151    +7     
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

A class responsible for generating the etag for a page.
Takes time based element publication into account as
before, but take additional arguments and is callable
from outside of the pages controller.
@tvdeyen
tvdeyen force-pushed the page-etag-generator branch from b37a80f to 20ed84d Compare March 11, 2026 20:52
@tvdeyen
tvdeyen merged commit 00adb02 into main Mar 12, 2026
27 checks passed
@tvdeyen
tvdeyen deleted the page-etag-generator branch March 12, 2026 09:16
@tvdeyen tvdeyen added the enhancement New feature or enhancement label Mar 20, 2026
@alchemycms-bot alchemycms-bot Bot mentioned this pull request Mar 24, 2026
@alchemycms-bot alchemycms-bot Bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Allow extending page ETags with dynamic components (e.g. asset digests)

2 participants