feat(color): Add g24_rec709_scene interop ID and use consistently - #5391
Merged
lgritz merged 1 commit intoAug 13, 2026
Merged
Conversation
This was added in the CIF texture color space recommendation 1.1. It was already used in PNG read and DPX. Now add in PNG write, TGA and RLA as well for consistency. Also fix wrong g22_rec709 and g18_rec709 without _scene suffix in TGA and RLA. No matching CICP was added so g24_rec709_display continues to be the interop ID on read. Both for compatibility, and because that CICP is already ambiguous. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Contributor
Author
|
CC @zachlewis |
34 tasks
7 tasks
zachlewis
added a commit
to zachlewis/OpenImageIO
that referenced
this pull request
Aug 17, 2026
- color_pvt.h: renumber ColorSpaceAnalysis mirror values to match the CSInfo flag split (is_srgb -> is_srgb_display/is_srgb_scene) adopted from upstream AcademySoftwareFoundation#5396; the color_ocio_pvt.h static_assert enforces this. - python-colorconfig refs (out.txt, out-ocio25.txt): on OCIO >= 2.5 the studio config declares interop_id 'ocio:g24_rec709_scene'; our cheap getter reports declared ids verbatim, unlike upstream's AcademySoftwareFoundation#5391 ref line. - color_test.cpp: make test_config_archive idempotent after a crashed run (clear the leftover working directory before create). Assisted-by: Claude Code / claude-fable-5 Signed-off-by: Zach Lewis <zachcanbereached@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was added in the CIF texture color space recommendation 1.1.
It was already used in PNG read and DPX. Now add in PNG write, TGA and RLA as well for consistency. Also fix wrong
g22_rec709andg18_rec709without_scenesuffix in TGA and RLA.No matching CICP was added so
g24_rec709_displaycontinues to be the interop ID on read. Both for compatibility, and because that CICP is already ambiguous (now explained in a comment).Ref #4980
Tests
Tests added to check for the presence of this interop ID.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.