perf: less redundant opening when files fail#5267
Merged
Merged
Conversation
When creating an ImageInput, if the initial guess (based on the file extension) fails to open, we try all the others in turn. This tries to make that a little cheaper by not doing a full open() but instead first checking for valid_file, which in theory is a much less expensive approximate check. Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
approved these changes
Jun 29, 2026
jessey-git
left a comment
jessey-git
left a comment
Contributor
There was a problem hiding this comment.
Yeah, the original code here always struck me as a odd to only do this for the do_open case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an ImageInput, if the initial guess (based on the file extension) fails to open, we try all the others in turn.
This tries to make that a little cheaper by not doing a full open() but instead first checking for valid_file, which in theory is a much less expensive approximate check.