Adsk Contrib - Update ReadTheDocs build OS and DirectX header install#2324
Open
doug-walker wants to merge 3 commits into
Open
Adsk Contrib - Update ReadTheDocs build OS and DirectX header install#2324doug-walker wants to merge 3 commits into
doug-walker wants to merge 3 commits into
Conversation
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
zachlewis
approved these changes
Jun 29, 2026
Collaborator
|
There is this warning in the readthedocs page about using the ubuntu-lts-latest tag. I think it's fine but still wanted to mention.
|
cozdas
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI Action was failing because RTD no longer supports ubuntu-20.04.
The Dependencies-latest Action was failing due to the windows-2025-vs2026 runner image apparently no longer having the DirectX headers available.
When find_package(directx-headers CONFIG QUIET) finds the vcpkg-installed package, it creates the Microsoft::DirectX-Headers imported target with INTERFACE_INCLUDE_DIRECTORIES set. We now pull that path into DirectX-Headers_INCLUDE_DIR before find_package_handle_standard_args runs — so the required-variable check passes and DirectX-Headers_FOUND stays TRUE.
This also means the target-creation block at line 69 (if(DirectX-Headers_FOUND AND NOT TARGET Microsoft::DirectX-Headers AND DirectX-Headers_INCLUDE_DIR)) will correctly skip when the vcpkg config already created Microsoft::DirectX-Headers.
@num3ric, please review the DirectX fix, thank you!