Extend range of arm_mult_q31 - #274
Closed
saturn691 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@saturn691 I have not benchmarked but I think this version would be slower. That's why we sometimes have different versions of the same kernel with different accuracy / speed tradedoff. It would be better as a new function since it is a different accuracy / speed tradeoff and I don't want to change too much the behavior of a function that is already in use. Your understanding is right : this version is using |
Contributor
|
I have created a new github issue to track this enhancement for future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the approach used by
arm_mult_q7andarm_mult_q15. The approach currently used would set the LSB to 0 due to the final left shift. My understanding of why that approach was used is because__SSAT(out, 32)doesn't work, because it operates on 32-bit integers, which means it cannot detect that0x80000000>0x7fffffff, as it will interpret this signed.On devices that support
sqdmulh, the compiler can optimise out the core calculation for that function. It must match these semantics, to generate the optimisations.