[WIP] add renomalization after the update - #2629
Open
zingale wants to merge 15 commits into
Open
Conversation
we now reject a solve if the mass fractions are too far out of [0, 1] also do the total energy update conservatively
in some sense, this mirrors what we would do with Strang or simplified-SDC, since we always renormalize after leaving the burner.
Member
Author
|
this requires #2586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
in some sense, this mirrors what we would do with Strang or
simplified-SDC, since we always renormalize after leaving the
burner.
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate