Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Fix imports to work as framework - #100

Merged
kcharwood merged 1 commit into
AFNetworking:masterfrom
juanuribeo13:master
Oct 28, 2015
Merged

Fix imports to work as framework#100
kcharwood merged 1 commit into
AFNetworking:masterfrom
juanuribeo13:master

Conversation

@juanuribeo13

Copy link
Copy Markdown
Contributor

This updates the AFNetworking dependencies imports to be system imports instead of local to fix the problem with cocoapods use_framework!

@damienrambout

Copy link
Copy Markdown

Please @mattt, merge this and push a new version on Cocoapods, otherwise it is impossible to use this lib as a pod framework.

@jairobjunior

Copy link
Copy Markdown

Hey @mattt, I am pretty sure that you have this in your backlog. I would love to stop using :git => 'https://github.com/juanuribeo13/AFOAuth2Manager.git', :commit => '7bf11369e5623a88313243001fb9b633e3ae15e6' for my prod version.

Thanks.

@juangdelvalle

Copy link
Copy Markdown

@mattt can you please release a new version on Cocoapods with this change, I have the pod referencing to @juanuribeo13 's change on my prod version and I would like to change it back.

@ealarco1

ealarco1 commented Sep 8, 2015

Copy link
Copy Markdown

@mattt I'd like to use this version as well. Could you please merge this and publish a new version?

@jrmiddle

Copy link
Copy Markdown

Piling on. Dear @mattt, as far as I can tell this is the last loose end for me as well.

@domness

domness commented Sep 14, 2015

Copy link
Copy Markdown

Would love this to get merged in :)

@DenTelezhkin

Copy link
Copy Markdown

@kcharwood @cnoon Guys, can you help with merging this in? Seems like very trivial thing to do.

Making my own fork for now...

@priteshshah1983

Copy link
Copy Markdown
Contributor

+1

yoonchulkoh pushed a commit to toreta/AFOAuth2Manager that referenced this pull request Oct 21, 2015
@tumatauenga

Copy link
Copy Markdown

+1

@kcharwood kcharwood added this to the 3.0.0 milestone Oct 28, 2015
kcharwood added a commit that referenced this pull request Oct 28, 2015
Fix imports to work as framework
@kcharwood
kcharwood merged commit ad54fed into AFNetworking:master Oct 28, 2015
@kcharwood

Copy link
Copy Markdown
Contributor

I'll get some more eyes on this project soon.

@rkheik rkheik mentioned this pull request Dec 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.