Preserve test output for dynamically skipped tests - #149
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 24, 2026
CurtHagenlocher
pushed a commit
to adbc-drivers/hiveserver2
that referenced
this pull request
Aug 24, 2026
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.61 to 1.5.85. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.85 ## What's Changed * Add release package code signing by @AArnott in AArnott/Xunit.SkippableFact#148 * Preserve test output for dynamically skipped tests by @AArnott in AArnott/Xunit.SkippableFact#149 ## New Contributors * @Youssef1313 made their first contribution in AArnott/Xunit.SkippableFact#109 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 24, 2026
github-actions Bot
added a commit
to secana/PeNet
that referenced
this pull request
Aug 27, 2026
Updated [Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact) from 1.5.61 to 1.5.85. <details> <summary>Release notes</summary> _Sourced from [Xunit.SkippableFact's releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._ ## 1.5.85 ## What's Changed * Add release package code signing by @AArnott in AArnott/Xunit.SkippableFact#148 * Preserve test output for dynamically skipped tests by @AArnott in AArnott/Xunit.SkippableFact#149 ## New Contributors * @Youssef1313 made their first contribution in AArnott/Xunit.SkippableFact#109 **Full Changelog**: AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85 Commits viewable in [compare view](AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Aug 27, 2026
This was referenced Aug 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16.
When a failure is converted into a skipped result, preserve the original result's captured output and execution time instead of using xUnit v2's TestSkipped implementation, which initializes both values to empty/zero.
Adds a regression test that writes through ITestOutputHelper before dynamically skipping.