Fix the "Someone" nickname problem (whatsapp) - #1931
Merged
Conversation
ilmaisin
changed the title
Contributor
Author
|
If i move to the place of the patch stops working. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| if sender, exists := b.contacts[senderJid]; exists { | ||
| if sender.FullName != "" { | ||
| return sender.FullName | ||
| func (b *Bwhatsapp) getSenderName(info types.MessageInfo) string { |
There was a problem hiding this comment.
Method Bwhatsapp.getSenderName has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Contributor
Author
|
I have noticed that the |
ilmaisin
changed the title
ilmaisin
marked this pull request as ready for review
December 3, 2022 20:56
ilmaisin
marked this pull request as draft
December 6, 2022 22:25
ilmaisin
marked this pull request as ready for review
December 6, 2022 22:35
|
Code Climate has analyzed commit 2200a9c and detected 0 issues on this pull request. View more on Code Climate. |
Owner
|
Thanks! |
selfhoster1312
pushed a commit
to selfhoster1312/matterbridge
that referenced
this pull request
Oct 10, 2025
* Apply patch to work around the "Someone" nickname problem * Code cleanup (whatsapp) * Cleanup * Code cleanup (whatsapp) * Re-examine if sender exists * Cleanup (whatsapp)
weskerty
pushed a commit
to weskerty/AcopleBot
that referenced
this pull request
Nov 30, 2025
* Apply patch to work around the "Someone" nickname problem * Code cleanup (whatsapp) * Cleanup * Code cleanup (whatsapp) * Re-examine if sender exists * Cleanup (whatsapp)
wbonis
pushed a commit
to styliteag/matterbridge
that referenced
this pull request
Feb 9, 2026
* Apply patch to work around the "Someone" nickname problem * Code cleanup (whatsapp) * Cleanup * Code cleanup (whatsapp) * Re-examine if sender exists * Cleanup (whatsapp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1876 and code cleanup