Skip to content

THREESCALE-9768 OpenAPI support for multiple flows in oauth - #368

Merged
eguzki merged 2 commits into
mainfrom
openapi-support-multiple-flows
Jun 26, 2023
Merged

THREESCALE-9768 OpenAPI support for multiple flows in oauth#368
eguzki merged 2 commits into
mainfrom
openapi-support-multiple-flows

Conversation

@eguzki

@eguzki eguzki commented Apr 24, 2023

Copy link
Copy Markdown
Member

@eguzki
eguzki marked this pull request as draft April 24, 2023 16:26
@codecov-commenter

codecov-commenter commented Apr 24, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b1776ef) 98.56% compared to head (ef7ee82) 98.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   98.56%   98.57%           
=======================================
  Files         349      349           
  Lines       17121    17159   +38     
=======================================
+ Hits        16876    16914   +38     
  Misses        245      245           
Impacted Files Coverage Δ
spec/shared_oas3_contexts.rb 100.00% <ø> (ø)
...t_command/openapi/update_service_oidc_conf_step.rb 94.44% <100.00%> (-0.30%) ⬇️
lib/3scale_toolbox/openapi/oas3.rb 97.91% <100.00%> (+0.04%) ⬆️
lib/3scale_toolbox/openapi/swagger.rb 97.56% <100.00%> (+0.15%) ⬆️
...t_command/openapi/update_service_oidc_conf_spec.rb 100.00% <100.00%> (ø)
spec/unit/openapi/oas3_spec.rb 100.00% <100.00%> (ø)
spec/unit/openapi/swagger_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkudlej

mkudlej commented May 4, 2023

Copy link
Copy Markdown

@eguzki hi, is this related to https://issues.redhat.com/browse/THREESCALE-5919 ?

@eguzki

eguzki commented May 4, 2023

Copy link
Copy Markdown
Member Author

@eguzki hi, is this related to https://issues.redhat.com/browse/THREESCALE-5919 ?

That one is about supporting openIdConnect https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#security-scheme-object type.

This is about supporting multiple flows for the oauth2 type

@eguzki
eguzki marked this pull request as ready for review June 26, 2023 09:20
@eguzki eguzki changed the title openapi support multiple flows in oauth OpenAPI support for multiple flows in oauth Jun 26, 2023
@eguzki
eguzki force-pushed the openapi-support-multiple-flows branch from ef7ee82 to 8fd5810 Compare June 26, 2023 09:23
@eguzki
eguzki force-pushed the openapi-support-multiple-flows branch from 8fd5810 to 3c9ca65 Compare June 26, 2023 12:08
@eguzki eguzki changed the title OpenAPI support for multiple flows in oauth THREESCALE-9768 OpenAPI support for multiple flows in oauth Jun 26, 2023
@eguzki
eguzki merged commit fdd0c69 into main Jun 26, 2023
@eguzki
eguzki deleted the openapi-support-multiple-flows branch June 26, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants