Skip to content

service copy command fix: do not copy endpoint url hosted services - #250

Merged
eguzki merged 2 commits into
masterfrom
fix-copy-product-deployment-option
Apr 22, 2020
Merged

service copy command fix: do not copy endpoint url hosted services#250
eguzki merged 2 commits into
masterfrom
fix-copy-product-deployment-option

Conversation

@eguzki

@eguzki eguzki commented Apr 17, 2020

Copy link
Copy Markdown
Member

Service copy command: do not copy endpoint url for services with hosted gateway

@miguelsorianod miguelsorianod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Left a comment related to the purpose of this changes

@eguzki

eguzki commented Apr 22, 2020

Copy link
Copy Markdown
Member Author

Doc updated and improved source code comments for clearness.

ready for review @miguelsorianod

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Apr 22, 2020
@eguzki
eguzki force-pushed the fix-copy-product-deployment-option branch from 40e48b3 to 4505168 Compare April 22, 2020 11:10

@miguelsorianod miguelsorianod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eguzki
eguzki force-pushed the fix-copy-product-deployment-option branch from 4505168 to ccc86f3 Compare April 22, 2020 13:39
@eguzki
eguzki merged commit 3e66fb2 into master Apr 22, 2020
@eguzki
eguzki deleted the fix-copy-product-deployment-option branch April 22, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants