Skip to content

Standard way to report errors - #246

Merged
miguelsorianod merged 2 commits into
masterfrom
THREESCALE-2349
Apr 8, 2020
Merged

Standard way to report errors#246
miguelsorianod merged 2 commits into
masterfrom
THREESCALE-2349

Conversation

@eguzki

@eguzki eguzki commented Mar 23, 2020

Copy link
Copy Markdown
Member

Fixes #80

@eguzki
eguzki requested a review from miguelsorianod March 23, 2020 17:54
@eguzki eguzki changed the title Threescale 2349 Standard way to report errors Mar 23, 2020
@eguzki

eguzki commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

ready for review @miguelsorianod

Comment thread docs/errors.md
Comment thread docs/errors.md
@miguelsorianod

Copy link
Copy Markdown
Contributor

As this changes the output content (now that I think about it, the same happens with json structured output), should we add some info in the future release notes telling that the shown output of some commands has changed? (in case someone is relying on that)

@miguelsorianod

Copy link
Copy Markdown
Contributor

Looks good to me.

Just some minor comments about how it works and feedback

@eguzki

eguzki commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

As this changes the output content (now that I think about it, the same happens with json structured output), should we add some info in the future release notes telling that the shown output of some commands has changed? (in case someone is relying on that)

The json structured output does not break backward compatibility, as it is optional.

Yes, indeed, when there are errors, this PR changes the output (in stderr). Adding release notes about this is a good idea

@eguzki eguzki assigned miguelsorianod and unassigned eguzki Apr 8, 2020
@miguelsorianod
miguelsorianod merged commit d475379 into master Apr 8, 2020
@miguelsorianod
miguelsorianod deleted the THREESCALE-2349 branch April 8, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: Have a standard way to report errors

2 participants