Update swagger parser - #110
Merged
Merged
Conversation
eguzki
force-pushed
the
swagger-custom-parser
branch
from
March 18, 2019 15:57
fdd774c to
0052888
Compare
Member
Author
|
tests implemented. Ready for review @mikz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently used swagger parsing library does not support vendor extensions swagger-rb/swagger-rb#5
Issue opened 4 years ago and it does not seem to be fixed soon.
This PR removes
swagger-rbparser library and implements swagger spec parsing for required elements. Basically, Swagger JSON Schema https://swagger.io/specification/ is used to validate swagger spec and then parsed required elements for 3scale toolbox. Just few lines of code.For Openapi 3.0 there is an active repository https://github.com/Nexmo/oas_parser
Fixes #105
Fixes #93