feat: add language and keyword filtering options#47
feat: add language and keyword filtering options#47jinethonazam-droid wants to merge 1 commit intoyankeexe:masterfrom
Conversation
iamteamstar
left a comment
iamteamstar
left a comment
There was a problem hiding this comment.
Hi there! Thanks for working on this issue. I can see your intention is to add --language and --keyword filters to the search functionality. However, there is a structural issue with this approach.
This project uses click as its CLI framework. By introducing argparse at the top level of main.py, we are mixing two different frameworks. Furthermore, the argparse logic here is never actually executed or integrated with the existing commands.
| @@ -1,32 +1,32 @@ | |||
| """Entrypoint of the CLI""" | |||
| import argparse | |||
|
|
|||
There was a problem hiding this comment.
Please remove the argparse implementation. The --language and --keyword arguments should be implemented using @click.option() inside search.py where the actual search command is defined
| config, | ||
| rate_limit, | ||
| search, | ||
| search, # THIS IS ALREADY THE COMMAND |
| $ gfi search | ||
|
|
||
| """ | ||
| pass |
There was a problem hiding this comment.
Please remove this inline comment as well before we merge
3 participants
This PR adds two new CLI flags to improve issue search:
Example usage:
$ python -m good_first_issues.main search --language Python --keyword "API"
Expected behavior: