Enable tube rendering by default - #509
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 2e70581): https://gcode-preview--pr509-codex-default-tube-r-ku72h992.web.app (expires Sun, 11 Oct 2026 06:59:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
| beforeEach(() => { | ||
| scene = new Scene(); | ||
| objectsManager = new ObjectsManager(scene, 0.4, 0.2, 0.6); | ||
| objectsManager.renderTubes = false; |
Collaborator
There was a problem hiding this comment.
Shouldn't the tests apply the defaults "by default"?
| */ | ||
| extrusionWidth?: number; | ||
| renderTubes = false; | ||
| renderTubes = true; |
remcoder
added a commit
that referenced
this pull request
Sep 11, 2026
A diagonal line renders, which was the whole point, but it gave nobody a reason to open the page. Same amount of setup, one build volume for the model to sit on, and enough moves to spell something. Sized for tube rendering, which #509 just made the default: a 0.6 x 0.2 mm extrusion is invisible on a 100 mm bed, so the letter sets its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extrusions now render as tubes when
renderTubesis omitted. Callers can still select flat lines withrenderTubes: false.Updated the README and existing tests to cover the new default and explicit line mode.
Validation: 978 tests pass with 100% coverage, build, type checking, and lint pass. Tests ran with
NODE_OPTIONS=--no-experimental-webstoragefor the local Node 26 environment.