Enable the ARM64 target on the ARM64EC ABI. - #1408
Conversation
|
LGTM. This does mean we should add that architecture to our CI target, can you give it a try? |
Done. CMake's recormendation seems to be to provide The strangest issue I had with the test is the git's msys2 envvar handling: When calling cmake (native) from bash (msys2), it converts |
serge-sans-paille
left a comment
serge-sans-paille
left a comment
There was a problem hiding this comment.
Looks good. Can you rebase on master brnach, this should make CI green again.
| CXXFLAGS: ${{ matrix.abi.cflags }} | ||
| - name: Build | ||
| run: cmake --build _build | ||
| - name: Testing xsimd |
There was a problem hiding this comment.
This is not testing the x86 emulation part, but I think it's ok, not our business to check that.
There was a problem hiding this comment.
IMO it would be our business to test the x64 intrinsics in arm64ec mode, but I've disabled them on purpose. On arm64ec, I think we should only allow to generate the native neon intrinsics instead.
ARM64EC enables both _M_AMD64 and _M_ARM64EC. We already exclude ARM64EC from the SSE2 detection, but it was missing for the X64 target detection. However we're now fine to enable the ARM64 target. At least my kernels compile fine (as good as on the raw arm64) on MSVC. Related: https://techcommunity.microsoft.com/blog/windowsosplatform/getting-to-know-arm64ec-defines-and-intrinsic-functions/2957235
I assume the /MANIFAST:NO shall be added as LDFLAGS, not overwrite it. So keep the old LDFLAGS.
2 participants
ARM64EC enables both _M_AMD64 and _M_ARM64EC. We already exclude ARM64EC from the SSE2 detection, but it was missing for the X64 target detection (by me in #1152, apparently on purpose).
However we're now fine to enable the ARM64 target. At least my kernels compile fine (as good as on the native arm64) on MSVC.
Related: https://techcommunity.microsoft.com/blog/windowsosplatform/getting-to-know-arm64ec-defines-and-intrinsic-functions/2957235
Tested on a local Windows arm64 machine with the arm64ec ABI:
now:
before enabling XSIMD_TARGET_ARM64: