WolfSSLEngine ByteBuffer offset/bounds fixes and JNI arrayOffset honoring

[JeremiahM37]

Fixes F-3487, F-3488, F-3489, F-3490, F-3492

• F-3490: SendAppData pos[]/limit[] OOB when ofst > 0 (re-indexed to i-ofst)
• F-3487: closeOutbound pre-handshake now closes inBound (was leaving it open)
• F-3488: wrap() null-check loop bound i<len -> i<ofst+len
• F-3489: unwrap() null/readOnly-check loop bound i<length -> i<ofst+length
• F-3492: read/write JNI now honors ByteBuffer.arrayOffset() for sliced buffers

Added regression tests

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #360

Scan targets checked: wolfssljni-bugs, wolfssljni-src

No new issues found in the changed files. ✅

[Copilot]

Pull request overview

Fixes several SSLEngine/WolfSSLSession ByteBuffer offset/bounds issues (including JNI honoring ByteBuffer.arrayOffset()), and adds regression tests to prevent reintroduction.

Changes:

• Fix WolfSSLEngine buffer-array offset handling (pos/limit indexing) and correct wrap/unwrap argument-validation loop bounds.
• Ensure closeOutbound() pre-handshake also closes inbound so isInboundDone() reflects completion.
• Update JNI ByteBuffer read/write paths to honor ByteBuffer.arrayOffset() for sliced/duplicated heap buffers, plus add regression tests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/java/com/wolfssl/provider/jsse/WolfSSLEngine.java	Fixes offset indexing/OOB issues in wrap/unwrap and SendAppData; adjusts pre-handshake closeOutbound inbound state.
native/com_wolfssl_globals.h	Adds cached JNI method ID declaration for ByteBuffer.arrayOffset().
native/com_wolfssl_WolfSSL.c	Caches ByteBuffer.arrayOffset() method ID during JNI_OnLoad and clears it on unload.
native/com_wolfssl_WolfSSLSession.c	Applies arrayOffset + position when reading/writing array-backed ByteBuffers in JNI.
src/test/com/wolfssl/test/WolfSSLSessionTest.java	Adds regression test ensuring read(ByteBuffer) honors arrayOffset() for sliced heap buffers.
src/test/com/wolfssl/provider/jsse/test/WolfSSLEngineTest.java	Adds regression tests for closeOutbound pre-handshake and wrap/unwrap buffer-array offset validation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.