Prep for 1.17 release#357
Merged
rlm2002 merged 13 commits intowolfSSL:masterfrom Apr 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Prepares the project for the 1.17 release by bumping versions, adjusting build/distribution behavior, improving test robustness (loopback/ephemeral ports), and tightening some native I/O handling.
Changes:
- Bump project/provider versions to 1.17 and add 1.17.0 release notes.
- Improve build/distribution reliability (drop gitignored
docs/lib, tolerate missing JNI lib dir, Windows build defines). - Make tests more robust/consistent (use loopback for local connects, avoid hardcoded ports, align console output, adjust memory leak test thresholds/timeouts).
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/com/wolfssl/test/WolfSSLSessionTest.java | Switch local client sockets to loopback and standardize “skipped” output text. |
| src/test/com/wolfssl/test/WolfSSLCertificateTest.java | Align console output strings and reduce noisy logging in extension-setter test. |
| src/test/com/wolfssl/test/WolfSSLCRLTest.java | Align console output formatting/indentation and refine test labels. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLTrustX509Test.java | Shorten/standardize printed test labels. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLSocketTest.java | Use ephemeral port with “bound port” handoff and switch connects to loopback; align output. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLSocketFactoryTest.java | Standardize “skipped” output text. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLSessionContextTest.java | Shorten/standardize printed test labels. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLServerSocketTest.java | Connect via loopback (and add import) and standardize “skipped” output text. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLServerSocketFactoryTest.java | Standardize “skipped” output text. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLKeyX509Test.java | Shorten/standardize printed test label. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLEngineTest.java | Use loopback for NIO socket tests and standardize printed test labels/skips. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLEngineMemoryLeakTest.java | Increase global timeout and relax acceptable growth threshold for “proper close” case; improve comments. |
| src/test/com/wolfssl/provider/jsse/test/WolfSSLContextTest.java | Standardize “skipped” output text. |
| src/java/com/wolfssl/provider/jsse/WolfSSLProvider.java | Bump provider version to 1.17. |
| pom.xml | Bump Maven project version to 1.17.0-SNAPSHOT. |
| platform/android_aosp/jsse_install.sh | Update copyright year. |
| native/com_wolfssl_WolfSSLSession.c | Check read/write return values in interrupt pipe helpers (EINTR-safe). |
| build.xml | Bump implementation version and make cleanjni delete non-fatal. |
| README.md | Update dependency snippet version to 1.17.0-SNAPSHOT. |
| Makefile | Remove gitignored docs/lib from distribution file list. |
| IDE/WIN/wolfssljni.vcxproj | Define _CRT_SECURE_NO_WARNINGS for /sdl-related warnings. |
| IDE/WIN/README.md | Document WOLFSSL_TLS13 (+FFDHE) requirement for Windows FIPS v2 builds. |
| ChangeLog.md | Add 1.17.0 draft release notes section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rlm2002
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preps for the 1.17 release, including version bumps and fixes found during the release cycle.
docs/libfromDIST_FILES; makeant cleanjnitolerate missinglib/WOLFSSL_TLS13in FIPS v2user_settings.h; define_CRT_SECURE_NO_WARNINGSfor/sdljsse_install.shread/writereturn values in SSLAppData interrupt pipe helpersWolfSSLEngineMemoryLeakTesttimeout to 180s; raise closed-engines leak threshold to 20 MB