Skip to content

Add cert/CRL capabilities: skid, akid, dist point, netscape#317

Merged
cconlon merged 1 commit intowolfSSL:masterfrom
padelsbach:crl-generation-cert-updates
Feb 18, 2026
Merged

Add cert/CRL capabilities: skid, akid, dist point, netscape#317
cconlon merged 1 commit intowolfSSL:masterfrom
padelsbach:crl-generation-cert-updates

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

This is a follow up to PR 315 which must be merged first. Must also merge related PRs on WolfSSL 9631 and 9713

@padelsbach padelsbach force-pushed the crl-generation-cert-updates branch from 0ea5522 to f739457 Compare January 30, 2026 18:48
@padelsbach padelsbach force-pushed the crl-generation-cert-updates branch 7 times, most recently from 7580592 to b75a5b9 Compare February 9, 2026 22:58
@cconlon cconlon requested a review from Copilot February 10, 2026 17:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for certificate and CRL generation extensions including Subject Key Identifier (SKID), Authority Key Identifier (AKID), CRL Distribution Points, and Netscape Certificate Type. It introduces a new WolfSSLCRL class for CRL generation and adds extension setter methods to WolfSSLCertificate. The implementation depends on wolfSSL PRs 9631 and 9713, which must be merged first.

Changes:

  • Added WolfSSLCRL class with comprehensive CRL generation API (new/sign/add revoked certificates/write to file)
  • Added certificate extension setter methods for SKID, AKID, CRL Distribution Points, and Netscape Cert Type to WolfSSLCertificate
  • Added NIDs and constants for new extension types to WolfSSL
  • Added comprehensive test coverage for CRL generation and certificate extension setters

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/java/com/wolfssl/WolfSSL.java Added NIDs for SKID, AKID, CRL dist points, Netscape cert type; added NS_CERT_TYPE constants; added CrlGenerationEnabled() method
src/java/com/wolfssl/WolfSSLCertificate.java Added extension setters for SKID/AKID/CRL dist points/Netscape type with two sets of methods (older naming + newer naming)
src/java/com/wolfssl/WolfSSLCRL.java New CRL generation class with methods to create, sign, and export CRLs
src/test/com/wolfssl/test/WolfSSLTestSuite.java Added WolfSSLCRLTest to test suite
src/test/com/wolfssl/test/WolfSSLCertificateTest.java Added testWolfSSLCertificateExtensionSetters test for new extension methods
src/test/com/wolfssl/test/WolfSSLCRLTest.java New comprehensive test file with 15 test methods covering all CRL operations
native/com_wolfssl_WolfSSL.c/h Implemented NID getters and CrlGenerationEnabled() native method
native/com_wolfssl_WolfSSLCertificate.c/h Implemented native extension setters for first set of methods only
native/com_wolfssl_WolfSSLCRL.c/h Complete native CRL generation implementation
java.sh Added compilation for WolfSSLCRL.c/.o and updated linker command
build.xml Added WolfSSLCRL to javah class list
platform/android_aosp/wolfssljni/Android.mk Added WolfSSLCRL.c to source files
IDE/Android/app/src/main/cpp/CMakeLists.txt Added WolfSSLCRL.c to CMake sources
IDE/WIN/wolfssljni.vcxproj* Added WolfSSLCRL source files to Windows project
examples/certs/update-certs.sh Added generation of test certificate with CRL distribution point
examples/certs/test/crl-dp-cert.pem New test certificate containing CRL distribution point extension

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread native/com_wolfssl_WolfSSLCRL.c Outdated
Comment thread native/com_wolfssl_WolfSSLCRL.c Outdated
Comment thread src/java/com/wolfssl/WolfSSLCertificate.java Outdated
Comment thread native/com_wolfssl_WolfSSLCRL.c Outdated
Comment thread native/com_wolfssl_WolfSSLCRL.c
Comment thread native/com_wolfssl_WolfSSLCRL.c
Comment thread src/java/com/wolfssl/WolfSSLCertificate.java
@padelsbach padelsbach force-pushed the crl-generation-cert-updates branch 4 times, most recently from 3ddeb59 to 99d15fb Compare February 16, 2026 18:26
@padelsbach padelsbach assigned cconlon and unassigned padelsbach Feb 17, 2026
@padelsbach padelsbach marked this pull request as ready for review February 18, 2026 19:08
@padelsbach padelsbach force-pushed the crl-generation-cert-updates branch 3 times, most recently from da4fc1c to b1a859a Compare February 18, 2026 19:22
@padelsbach padelsbach force-pushed the crl-generation-cert-updates branch from b1a859a to 1efe944 Compare February 18, 2026 19:23
@cconlon cconlon merged commit 194db83 into wolfSSL:master Feb 18, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants