Add cert/CRL capabilities: skid, akid, dist point, netscape#317
Merged
cconlon merged 1 commit intowolfSSL:masterfrom Feb 18, 2026
Merged
Add cert/CRL capabilities: skid, akid, dist point, netscape#317cconlon merged 1 commit intowolfSSL:masterfrom
cconlon merged 1 commit intowolfSSL:masterfrom
Conversation
0ea5522 to
f739457
Compare
7580592 to
b75a5b9
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for certificate and CRL generation extensions including Subject Key Identifier (SKID), Authority Key Identifier (AKID), CRL Distribution Points, and Netscape Certificate Type. It introduces a new WolfSSLCRL class for CRL generation and adds extension setter methods to WolfSSLCertificate. The implementation depends on wolfSSL PRs 9631 and 9713, which must be merged first.
Changes:
- Added
WolfSSLCRLclass with comprehensive CRL generation API (new/sign/add revoked certificates/write to file) - Added certificate extension setter methods for SKID, AKID, CRL Distribution Points, and Netscape Cert Type to
WolfSSLCertificate - Added NIDs and constants for new extension types to
WolfSSL - Added comprehensive test coverage for CRL generation and certificate extension setters
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/java/com/wolfssl/WolfSSL.java | Added NIDs for SKID, AKID, CRL dist points, Netscape cert type; added NS_CERT_TYPE constants; added CrlGenerationEnabled() method |
| src/java/com/wolfssl/WolfSSLCertificate.java | Added extension setters for SKID/AKID/CRL dist points/Netscape type with two sets of methods (older naming + newer naming) |
| src/java/com/wolfssl/WolfSSLCRL.java | New CRL generation class with methods to create, sign, and export CRLs |
| src/test/com/wolfssl/test/WolfSSLTestSuite.java | Added WolfSSLCRLTest to test suite |
| src/test/com/wolfssl/test/WolfSSLCertificateTest.java | Added testWolfSSLCertificateExtensionSetters test for new extension methods |
| src/test/com/wolfssl/test/WolfSSLCRLTest.java | New comprehensive test file with 15 test methods covering all CRL operations |
| native/com_wolfssl_WolfSSL.c/h | Implemented NID getters and CrlGenerationEnabled() native method |
| native/com_wolfssl_WolfSSLCertificate.c/h | Implemented native extension setters for first set of methods only |
| native/com_wolfssl_WolfSSLCRL.c/h | Complete native CRL generation implementation |
| java.sh | Added compilation for WolfSSLCRL.c/.o and updated linker command |
| build.xml | Added WolfSSLCRL to javah class list |
| platform/android_aosp/wolfssljni/Android.mk | Added WolfSSLCRL.c to source files |
| IDE/Android/app/src/main/cpp/CMakeLists.txt | Added WolfSSLCRL.c to CMake sources |
| IDE/WIN/wolfssljni.vcxproj* | Added WolfSSLCRL source files to Windows project |
| examples/certs/update-certs.sh | Added generation of test certificate with CRL distribution point |
| examples/certs/test/crl-dp-cert.pem | New test certificate containing CRL distribution point extension |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3ddeb59 to
99d15fb
Compare
da4fc1c to
b1a859a
Compare
b1a859a to
1efe944
Compare
cconlon
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR 315 which must be merged first. Must also merge related PRs on WolfSSL 9631 and 9713