JSSE: add Android non-standard checkServerTrusted() in X509TrustManager#288
JSSE: add Android non-standard checkServerTrusted() in X509TrustManager#288rlm2002 merged 2 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the non-standard Android X509TrustManager API that includes OCSP and SCT data parameters for certificate chain validation. The implementation adds OCSP response verification using native wolfSSL's CertManager functionality while ignoring SCT data since wolfSSL doesn't support it.
Key Changes:
- Added Android-specific
checkServerTrustedmethod with OCSP/SCT parameters - Implemented OCSP response validation through native wolfSSL CertManager
- Added comprehensive unit tests for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| WolfSSLTrustX509.java | Implements the Android-specific checkServerTrusted method with OCSP validation |
| WolfSSLCertManager.java | Adds CertManagerCheckOCSPResponse method for OCSP response validation |
| com_wolfssl_WolfSSLCertManager.h | Declares native JNI method for OCSP response checking |
| com_wolfssl_WolfSSLCertManager.c | Implements native OCSP response validation using wolfSSL |
| WolfSSLTrustX509Test.java | Comprehensive test suite for the new Android API functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4c392ad to
4eb1bea
Compare
4eb1bea to
293e485
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
88a0110 to
8db9ab6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8db9ab6 to
a0eb163
Compare
This PR implements the following non-standard Android X509TrustManager API:
This also verifies OCSP response data if passed in using native wolfSSL's CertManager functionality.
tlsSctDatais ignored since native wolfSSL does not support SCT.This includes unit tests of this functionality as well.