add get/setUseCipherSuitesOrder to ParametersHelper#287
Merged
cconlon merged 2 commits intowolfSSL:masterfrom Oct 15, 2025
Merged
add get/setUseCipherSuitesOrder to ParametersHelper#287cconlon merged 2 commits intowolfSSL:masterfrom
cconlon merged 2 commits intowolfSSL:masterfrom
Conversation
dae452b to
1307631
Compare
Member
|
Looks good so far. Please continue with implementation of wrapping native wolfSSL's |
4dbd6bc to
01e4e80
Compare
wrap get/set SNIMatchers and UsecipherSuitesOrder with try/catch
01e4e80 to
a4631ad
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for client cipher suite preference ordering in wolfSSL, adding the ability to honor the client's cipher suite order when establishing TLS connections.
- Adds
get/setUseCipherSuitesOrdermethods toWolfSSLParametersHelperwith reflection-based handling - Implements native
useClientSuites()wrapper aroundwolfSSL_UseClientSuites() - Adds comprehensive unit test to verify server honors client cipher suite preferences
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| WolfSSLParametersHelper.java | Adds reflection support for UseCipherSuitesOrder parameter handling |
| WolfSSLEngineHelper.java | Implements logic to call useClientSuites() when server should honor client preferences |
| WolfSSLSession.java | Adds useClientSuites() method wrapper for native wolfSSL function |
| com_wolfssl_WolfSSLSession.h | Adds JNI header declaration for useClientSuites |
| com_wolfssl_WolfSSLSession.c | Implements JNI native method calling wolfSSL_UseClientSuites() |
| WolfSSLSocketTest.java | Adds unit test and converts C-style comments to Java-style |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cconlon
requested changes
Oct 15, 2025
Member
cconlon
left a comment
There was a problem hiding this comment.
See minor comments from Copilot, thanks
…LEngineHelper JSSE: add unit test for useClientSuites add alias for cipher to cipher suite preference test
a4631ad to
57f1dfe
Compare
cconlon
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
out.setUseCipherSuitesOrder(in.getUseCipherSuitesOrder());andret.setUseCipherSuitesOrder(in.getUseCipherSuitesOrder());to ParametersHelper.Wraps
wolfSSL_UseClientSuites()to set native ssl to use client's order of preference if SSLParameteruseCipherSuiteOrder = falsewhen callingsetLocalCiphers()in WolfSSLEngineHelper.Add unit test to ensure function works properly.
Change was made to pass SunJSSE test
SSLContextImpl/DefaultCipherSuitePreference.java