Fix issues found in static analysis#9788
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 17, 2026
Merged
Conversation
Member
LinuxJedi
commented
Feb 17, 2026
LinuxJedi
commented
- Fix missing cleanup on error in wc_XChaCha20Poly1305_crypt_oneshot: change early return to goto out so ForceZero and free are called
- Fix memory leak in wc_DeCompressDynamic: free tmp buffer before early return on avail_out size check failure
- Fix unconditional mutex unlock in PQC sign functions (falcon, sphincs, dilithium): only call unlock when lock was acquired
- Remove dead oqssig NULL checks in falcon sign/verify that are unreachable after the preceding SIG_TYPE_E assignment
- Fix missing cleanup on error in wc_XChaCha20Poly1305_crypt_oneshot: change early return to goto out so ForceZero and free are called - Fix memory leak in wc_DeCompressDynamic: free tmp buffer before early return on avail_out size check failure - Fix unconditional mutex unlock in PQC sign functions (falcon, sphincs, dilithium): only call unlock when lock was acquired - Remove dead oqssig NULL checks in falcon sign/verify that are unreachable after the preceding SIG_TYPE_E assignment
dgarske
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.