Skip to content

Ensure length is at least ID_LEN in SetTicket. #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SparkiDev merged 4 commits into from
Mar 2, 2026
Merged

Ensure length is at least ID_LEN in SetTicket. #9782

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0463e37
Pad session ID with 0s if session ticket length is less than ID_LEN.
kareem-wolfssl Feb 23, 2026
9a0c18c
Work around error: enumerated and non-enumerated type in conditional …
kareem-wolfssl Feb 24, 2026
3d5c03a
Merge branch 'master' of https://github.com/wolfSSL/wolfssl into zd21204
kareem-wolfssl Feb 27, 2026
aaf6aa5
Code review feedback
kareem-wolfssl Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34824,6 +34824,8 @@ int SendCertificateVerify(WOLFSSL* ssl)
#ifdef HAVE_SESSION_TICKET
int SetTicket(WOLFSSL* ssl, const byte* ticket, word32 length)
{
word32 sessIdLen = 0;
Comment thread
SparkiDev marked this conversation as resolved.
Outdated

if (!HaveUniqueSessionObj(ssl))
return MEMORY_ERROR;

Expand All @@ -34845,6 +34847,10 @@ int SetTicket(WOLFSSL* ssl, const byte* ticket, word32 length)
ssl->session->ticketLen = (word16)length;

if (length > 0) {
if (length >= ID_LEN)
sessIdLen = ID_LEN;
else
sessIdLen = length;
XMEMCPY(ssl->session->ticket, ticket, length);
if (ssl->session_ticket_cb != NULL) {
ssl->session_ticket_cb(ssl,
Expand All @@ -34856,15 +34862,17 @@ int SetTicket(WOLFSSL* ssl, const byte* ticket, word32 length)
ssl->options.haveSessionId = 1;
#ifdef WOLFSSL_TLS13
if (ssl->options.tls1_3) {
XMEMSET(ssl->session->sessionID, 0, ID_LEN);
XMEMCPY(ssl->session->sessionID,
ssl->session->ticket + length - ID_LEN, ID_LEN);
ssl->session->ticket + length - sessIdLen, sessIdLen);
Comment thread
SparkiDev marked this conversation as resolved.
Outdated
ssl->session->sessionIDSz = ID_LEN;
}
else
#endif
{
XMEMSET(ssl->arrays->sessionID, 0, ID_LEN);
XMEMCPY(ssl->arrays->sessionID,
ssl->session->ticket + length - ID_LEN, ID_LEN);
ssl->session->ticket + length - sessIdLen, sessIdLen);
Comment thread
SparkiDev marked this conversation as resolved.
Outdated
ssl->arrays->sessionIDSz = ID_LEN;
}
}
Expand Down
Loading