20260904-linuxkm-misc by douzzer · Pull Request #11382 · wolfSSL/wolfssl

douzzer · 2026-09-04T19:14:05Z

linuxkm/linuxkm_wc_port.h:

reduce WC_LINUXKM_MAX_NS_WITHOUT_YIELD from 1 second to 25 ms for better kernel citizenship.
add WC_DEBUG_FORCE_KERNEL_SETTINGS for inhibiting #errors on unsupported configurations.
add __extension__ annotation to macros that need it.
add wc_svr_disallowed_count_reset() and wc_svr_disallowed_count_current().
fix CAN_SAVE_VECTOR_REGISTERS() to honor DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_{ON,OFF}.
add WC_RELAX_LONG_LOOP() to DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_OFF variant of SAVE_VECTOR_REGISTERS2().
allow for fully user-supplied SAVE_VECTOR_REGISTERS() and friends.

linuxkm/module_hooks.c:

add WOLFSSL_DEBUG_TRACE_ERROR_CODES coverage for all system error codes used by module_hooks.c and its includes.
implement double-run wolfCrypt_IntegrityTest_fips() and wc_RunAllCast_fips() in WC_C_DYNAMIC_FALLBACK configurations, once with acceleration on (leveraging fallback instrumentation to fail the module if any fallbacks occur), and once with it forced off using DISABLE_VECTOR_REGISTERS().

linuxkm/module_hooks.c: when DEBUG_VECTOR_REGISTER_ACCESS_FUZZING or DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_ON, inhibit DISABLE_VECTOR_REGISTERS() exercises and auditing of wc_svr_disallowed_count_current().

linuxkm/module_hooks.c: implement /sys/module/libwolfssl/FIPS_optest_run_code_audit_accel and /sys/module/libwolfssl/FIPS_optest_run_code_audit_c.

linuxkm/module_hooks.c: in wolfssl_init(), when WOLFSSL_AESNI but not USE_INTEL_SPEEDUP, don't expect wc_svr_disallowed_count_current() to increase for wolfCrypt_IntegrityTest_fips() (no AES in it).

linuxkm/module_hooks.c and wolfcrypt/src/rng_bank.c: fixes for external review of FIPS_OPTEST/LKCAPI coexistence and affinity lock error handling.

in FIPS_optest_trig_handler(), implement assiduous (atomic-based) mutual exclusion with LKCAPI registration.

in wc_rng_bank_checkout(), propagate INTERRUPTED_E from bank->affinity_lock_cb rather than swallowing it -- caller-requested interruption must abort checkout, consistent with the WC_CHECK_FOR_INTR_SIGNALS() handling in the same loop; other affinity lock errors continue to be tolerated (affinity is advisory).

linuxkm/linuxkm-fips-hash.c: in hmac_update_cb(), use wc_HmacUpdate(), not wc_HmacUpdate_fips(), for compatibility with dev-no-post.

linuxkm/lkcapi_glue.c: tolerate !HAVE_FIPS with CONFIG_CRYPTO_FIPS, with a runtime check that kernel fips_enabled is zero.

linuxkm/module_hooks.c:

add libwolfssl_inited flag variable and use it for proper error-path cleanup;
call wc_linuxkm_allocate_svr_states() and wc_linuxkm_free_svr_states() explicitly in FIPS builds (avoid atomic-context synchronous call to wc_linuxkm_allocate_svr_states() via fipEntry());
add missing WOLFSSL_FIPS_DEV_NO_POST gates;
in wc_lkm_LockMutex(), return BUSY_E immediately if in_nmi().

tested with

wolfssl-multi-test.sh ...
check-source-text
quantum-safe-wolfssl-all-crypto-only-intelasm-sp-asm-fips-dev-linuxkm-next-clang-tidy
quantum-safe-wolfssl-all-crypto-only-intelasm-sp-asm-sp-linuxkm-6.12-insmod
quantum-safe-wolfssl-all-crypto-only-intelasm-sp-asm-fips-dev-linuxkm-next-insmod
linuxkm-6.15-all-cryptonly-quantum-safe-allintelasm-LKCAPI-insmod-crypto-fuzzer-kmemleak
linuxkm-6.15-all-cryptonly-quantum-safe-allintelasm-LKCAPI-insmod-crypto-fuzzer-ksan
linuxkm-fips-dev-insmod-wolfguard-cust-kernel-3

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11382

Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

github-actions · 2026-09-04T23:15:32Z

MemBrowse Memory Report

linuxkm-pie

Data: __patchable_function_entries +8 B (+0.0%, 27,048 B)

linuxkm-standard

Data: __patchable_function_entries +8 B (+0.0%, 49,848 B)
No memory changes detected for:
gcc-arm-cortex-m0plus
gcc-arm-cortex-m3
gcc-arm-cortex-m4
gcc-arm-cortex-m4-baremetal
gcc-arm-cortex-m4-crypto-only
gcc-arm-cortex-m4-dtls13
gcc-arm-cortex-m4-min-ecc
gcc-arm-cortex-m4-openssl-compat
gcc-arm-cortex-m4-pkcs7
gcc-arm-cortex-m4-pq
gcc-arm-cortex-m4-rsa-only
gcc-arm-cortex-m4-sp-math
gcc-arm-cortex-m4-tls12
gcc-arm-cortex-m4-tls13
gcc-arm-cortex-m7
gcc-arm-cortex-m7-pq
gcc-arm-cortex-m7-tls13
stm32-sim-stm32h753

* reduce WC_LINUXKM_MAX_NS_WITHOUT_YIELD from 1 second to 25 ms for better kernel citizenship. * add WC_DEBUG_FORCE_KERNEL_SETTINGS for inhibiting #errors on unsupported configurations. * add __extension__ annotation to macros that need it. * add wc_svr_disallowed_count_reset() and wc_svr_disallowed_count_current(). * fix CAN_SAVE_VECTOR_REGISTERS() to honor DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_{ON,OFF}. * add WC_RELAX_LONG_LOOP() to DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_OFF variant of SAVE_VECTOR_REGISTERS2(). * allow for fully user-supplied SAVE_VECTOR_REGISTERS() and friends.

* add WOLFSSL_DEBUG_TRACE_ERROR_CODES coverage for all system error codes used by module_hooks.c and its includes. * implement double-run wolfCrypt_IntegrityTest_fips() and wc_RunAllCast_fips() in WC_C_DYNAMIC_FALLBACK configurations, once with acceleration on (leveraging fallback instrumentation to fail the module if any fallbacks occur), and once with it forced off using DISABLE_VECTOR_REGISTERS().

…DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_ON, inhibit DISABLE_VECTOR_REGISTERS() exercises and auditing of wc_svr_disallowed_count_current().

…run_code_audit_accel and /sys/module/libwolfssl/FIPS_optest_run_code_audit_c.

… USE_INTEL_SPEEDUP, don't expect wc_svr_disallowed_count_current() to increase for wolfCrypt_IntegrityTest_fips() (no AES in it).

…PI coexistence: in FIPS_optest_trig_handler(), implement assiduous (atomic-based) mutual exclusion with LKCAPI registration.

…, not wc_HmacUpdate_fips(), for compatibility with dev-no-post.

…ith a runtime check that kernel fips_enabled is zero.

* add libwolfssl_inited flag variable and use it for proper error-path cleanup; * call wc_linuxkm_allocate_svr_states() and wc_linuxkm_free_svr_states() explicitly in FIPS builds (avoid atomic-context synchronous call to wc_linuxkm_allocate_svr_states() via fipEntry()); * add missing WOLFSSL_FIPS_DEV_NO_POST gates; * in wc_lkm_LockMutex(), return BUSY_E immediately if in_nmi().

…batching several chunks within a single SAVE_VECTOR_REGISTERS2() bracket (entails adding WALK_ATOMIC to calls that affect walk dynamics during the locked batches).

…ERROR_CODES_PER_FILE and WOLFSSL_DEBUG_TRACE_ERROR_CODES_THIS_FILE (file-scoped code traces).

…G_PREEMPT_RT kernels.

…WOLFSSL_ATOMIC_LOAD() and WOLFSSL_ATOMIC_STORE(), use __ATOMIC_SEQ_CST rather than __ATOMIC_CONSUME/__ATOMIC_RELEASE, for consistency with semantics of the primary C11 bindings to atomic_load() and atomic_store().

…rly, and add WC_LINUXKM_HAVE_MY_KALLSYMS_LOOKUP_NAME.

…S_optest_trig_audit_c_attr to use distinct handlers that pass distinct mode arguments to a multi-personality FIPS_optest_trig_common(), properly implementing the SVR-auditing variants of the FIPS_optest_run_code sysfs node.

…ECTOR_REGISTER_ACCESS_ALWAYS_{OFF,ON} settings.

* always call wolfCrypt_Init() directly, even in TLS builds, to assure mutex-free scheduler context during allocations; * convert sysfs nodes from struct kobj_attribute to struct module_attribute, matching the module_sysfs_ops dispatch on THIS_MODULE->mkobj.kobj, for compatibility with CONFIG_CFI_CLANG (kCFI) kernels.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11382

Scan targets checked: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

wolfSSL-Fenrir-bot · 2026-09-10T05:14:21Z

    }

+#if WC_LINUXKM_GCM_SVR_BATCH > 0
+    if (SAVE_VECTOR_REGISTERS2() == 0) {


GCM batching moves AAD allocation into atomic context · Kernel memory safety

SAVE_VECTOR_REGISTERS2() makes fragmented-AAD allocation and freeing run with preemption disabled, forcing unreliable GFP_ATOMIC allocation. With vmalloc storage, free() reaches kvfree() outside its permitted task context. Unlike known #9680, this concerns allocation context, not bounds.

Related known finding #12850 (similar but distinct): Both affect AesGcmCrypt_1 GCM processing, but #12850 writes unauthenticated plaintext before final tag verification; this performs AAD allocation/free under a saved-vector atomic context. The faulting operations, root causes, and fixes differ.

Suggested fix: Allocate and free the AAD bounce buffer outside the saved-vector region; bracket only the GCM operations that require SIMD.
Basis: Linux Memory Management APIs: GFP_ATOMIC is a non-sleeping emergency-pool allocation, while kvfree() requires preemptible task or non-NMI interrupt context.

wolfSSL-Fenrir-bot · 2026-09-10T05:14:21Z

+    ret = linuxkm_sysfs_install_attr(&FIPS_optest_trig_audit_accel_attr.attr, &installed_sysfs_FIPS_optest_trig_audit_accel_files);
+    if (ret != 0) {
+        pr_err("ERROR: linuxkm_sysfs_install_attr() failed for %s (code %d).\n", FIPS_optest_trig_audit_accel_attr.attr.name, ret);
+        (void)libwolfssl_cleanup();


New optest sysfs nodes lack init-failure rollback · Resource leaks on error paths

The new audit attributes are installed sequentially, but later failures call only libwolfssl_cleanup(), which removes no sysfs files. Successful earlier installs survive the init abort. This is adjacent to known #7892 but covers the newly added audit nodes.

Related known finding #7892 (similar but distinct): Both are wolfssl_init error-path rollback omissions involving sysfs state, but #7892 covers existing post-initialization and FIPS optest-trigger paths, while this covers newly added audit attributes installed sequentially. The installed nodes and rollback paths differ, so a separate patch is required.

Suggested fix: Rollback every optest attribute whose installed flag is set before any post-install initialization error returns.
Basis: Linux sysfs API pairing contract: each successful sysfs_create_file() installation is released with sysfs_remove_file().

douzzer requested review from wolfSSL-Bot and wolfSSL-Fenrir-bot September 4, 2026 19:14

douzzer assigned wolfSSL-Bot Sep 4, 2026

philljj self-requested a review September 4, 2026 19:17

wolfSSL-Fenrir-bot requested changes Sep 4, 2026

View reviewed changes

Comment thread linuxkm/linuxkm_wc_port.h

Comment thread linuxkm/module_hooks.c Outdated

philljj assigned douzzer and unassigned wolfSSL-Bot Sep 6, 2026

douzzer added 21 commits September 9, 2026 20:29

linuxkm/module_hooks.c: when DEBUG_VECTOR_REGISTER_ACCESS_FUZZING or …

cb46297

…DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_ON, inhibit DISABLE_VECTOR_REGISTERS() exercises and auditing of wc_svr_disallowed_count_current().

linuxkm/module_hooks.c: implement /sys/module/libwolfssl/FIPS_optest_…

f59b0e7

…run_code_audit_accel and /sys/module/libwolfssl/FIPS_optest_run_code_audit_c.

linuxkm/module_hooks.c: in wolfssl_init(), when WOLFSSL_AESNI but not…

6a60c7d

… USE_INTEL_SPEEDUP, don't expect wc_svr_disallowed_count_current() to increase for wolfCrypt_IntegrityTest_fips() (no AES in it).

linuxkm/module_hooks.c: fixes for external review of FIPS_OPTEST/LKCA…

58ed029

…PI coexistence: in FIPS_optest_trig_handler(), implement assiduous (atomic-based) mutual exclusion with LKCAPI registration.

linuxkm/linuxkm-fips-hash.c: in hmac_update_cb(), use wc_HmacUpdate()…

cde88d2

…, not wc_HmacUpdate_fips(), for compatibility with dev-no-post.

linuxkm/lkcapi_glue.c: tolerate !HAVE_FIPS with CONFIG_CRYPTO_FIPS, w…

19de082

…ith a runtime check that kernel fips_enabled is zero.

linuxkm/lkcapi_aes_glue.c: implement WC_LINUXKM_{GCM,XTS}_SVR_BATCH, …

5a79b8f

…batching several chunks within a single SAVE_VECTOR_REGISTERS2() bracket (entails adding WALK_ATOMIC to calls that affect walk dynamics during the locked batches).

linuxkm/lkcapi_aes_glue.c: recognize a WC_LINUXKM_SVR_NO_BATCHING macro.

f095fa2

wolfssl/wolfcrypt/error-crypt.h: add support for WOLFSSL_DEBUG_TRACE_…

ec2e1f2

…ERROR_CODES_PER_FILE and WOLFSSL_DEBUG_TRACE_ERROR_CODES_THIS_FILE (file-scoped code traces).

linuxkm/module_hooks.c: in wc_lkm_LockMutex(), fix dynamics in !CONFI…

d5bd6fa

…G_PREEMPT_RT kernels.

.wolfssl_known_macro_extras: add WC_LINUXKM_SVR_NO_BATCHING.

3747240

linuxkm/module_hooks.c: move my_kallsyms_lookup_name() declaration ea…

d26ffdc

…rly, and add WC_LINUXKM_HAVE_MY_KALLSYMS_LOOKUP_NAME.

.wolfssl_known_macro_extras: add __ATOMIC_SEQ_CST.

684c916

configure.ac: fix improper use of == test operator.

8d0c790

linuxkm/linuxkm_wc_port.h: restore exclusion of contradictory DEBUG_V…

06c4358

…ECTOR_REGISTER_ACCESS_ALWAYS_{OFF,ON} settings.

douzzer force-pushed the 20260904-linuxkm-misc branch from 2c52057 to 8864af4 Compare September 10, 2026 04:37

douzzer commented Sep 10, 2026

View reviewed changes

Comment thread linuxkm/linuxkm_wc_port.h

douzzer commented Sep 10, 2026

View reviewed changes

Comment thread linuxkm/module_hooks.c Outdated

douzzer requested a review from wolfSSL-Fenrir-bot September 10, 2026 04:38

douzzer assigned wolfSSL-Bot and unassigned douzzer Sep 10, 2026

wolfSSL-Fenrir-bot requested changes Sep 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

20260904-linuxkm-misc - #11382

20260904-linuxkm-misc#11382
douzzer wants to merge 21 commits into
wolfSSL:masterfrom
douzzer:20260904-linuxkm-misc

douzzer commented Sep 4, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Uh oh!

wolfSSL-Fenrir-bot Sep 10, 2026

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

douzzer commented Sep 4, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11382

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

linuxkm-pie

linuxkm-standard

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11382

Uh oh!

wolfSSL-Fenrir-bot Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Sep 4, 2026 •

edited

Loading