Fix double-free of she2 in she_test()#10283
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Apr 23, 2026
Merged
Conversation
night1rider
force-pushed
the
SHE-test-double-free-fix
branch
from
74169f4 to
d673b62
Compare
|
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10283
No scan targets match the changed files in this PR. Review skipped.
JacobBarthelmeh
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
she_test()inwolfcrypt/test/test.cfreesshe2twice on several code paths.WC_FREE_VARdoes not null its argument, so the exit-label cleanup atexit_SHE_Test:re-frees the same pointer that was already freed mid-test.Fix
Set
she2 = NULLafter every intermediateWC_FREE_VAR(she2, HEAP_HINT)so the subsequent free atexit_SHE_Test:seesNULLand becomes a no-op. Three sites updated.