20260416-SNI-WOLFSSL_HOST_NAME_MAX#10237
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Apr 16, 2026
Merged
Conversation
…0182): * Fix OOB heap reads via TLSX_ExtractEch() by preemptively rejecting oversized SNI names in TLSX_UseSNI(). * In TLSX_EchChangeSNI(), don't attempt to truncate if an oversized name is seen, just return error. * Move definition of WOLFSSL_HOST_NAME_MAX to an ungated context in ssl.h, and use it consistently in tls.c, eliminating the duplicative WOLFSSL_HOST_NAME_MAX.
douzzer
requested review from
SparkiDev,
embhorn,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
dgarske
approved these changes
Apr 16, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10237
Scan targets checked: wolfssl-bugs, wolfssl-compliance, wolfssl-consttime, wolfssl-defaults, wolfssl-mutation, wolfssl-proptest, wolfssl-src, wolfssl-zeroize
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/tls.c,wolfssl/ssl.h,tests/api.c: followup to ff7a32d (#10182):Fix OOB heap reads via
TLSX_ExtractEch()by preemptively rejecting oversized SNI names inTLSX_UseSNI().In
TLSX_EchChangeSNI(), don't attempt to truncate if an oversized name is seen, just return error.Move definition of
WOLFSSL_HOST_NAME_MAXto an ungated context inssl.h, and use it consistently intls.c, eliminating the duplicativeWOLFSSL_HOST_NAME_MAX.tested with