use heap hints where possible in benchmark#10121
use heap hints where possible in benchmark#10121JacobBarthelmeh wants to merge 4 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the wolfCrypt benchmark to pass heap hints into allocation/init APIs so benchmark objects can be allocated from the configured heap.
Changes:
- Pass
HEAP_HINTintoXMALLOC/XFREEfor benchmark stats tracking. - Pass
HEAP_HINTinto several*_Initfunctions used by benchmark routines. - Switch Falcon initialization to
wc_falcon_init_ex(...)to allow heap-hint/device-id aware init.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Retest this please Jenkins, history unavailable. |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10121
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
Findings: 2
1 finding(s) posted as inline comments (see file-level comments below)
Info (1)
Stale docstring still says heap is Unused
File: wolfcrypt/src/wc_xmss.c:808
Function: wc_XmssKey_Init
Category: Dead/unreachable code
Doxygen comment for wc_XmssKey_Init still declares @param [in] heap Unused., but the function now stores key->heap = heap;. The (void) heap; was removed in this PR but the docstring was not updated.
* @param [in] heap Unused.
* @param [in] devId Unused.Recommendation: Update the docstring to describe heap as the dynamic memory hint used by subsequent allocations.
This review was generated automatically by Fenrir. Findings are non-blocking.
No description provided.