Skip to content

use heap hints where possible in benchmark - #10121

Merged
dgarske merged 4 commits into
wolfSSL:masterfrom
JacobBarthelmeh:bench
May 5, 2026
Merged

dgarske merged 4 commits into
wolfSSL:masterfrom
JacobBarthelmeh:bench

Conversation

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor

No description provided.

@JacobBarthelmeh JacobBarthelmeh self-assigned this Apr 1, 2026
Copilot AI review requested due to automatic review settings April 1, 2026 21:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the wolfCrypt benchmark to pass heap hints into allocation/init APIs so benchmark objects can be allocated from the configured heap.

Changes:

  • Pass HEAP_HINT into XMALLOC/XFREE for benchmark stats tracking.
  • Pass HEAP_HINT into several *_Init functions used by benchmark routines.
  • Switch Falcon initialization to wc_falcon_init_ex(...) to allow heap-hint/device-id aware init.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/benchmark/benchmark.c
Comment thread wolfcrypt/benchmark/benchmark.c
@github-actions

github-actions Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/src/wc_xmss.c
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/src/wc_xmss_impl.c
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
Comment thread wolfcrypt/benchmark/benchmark.c Outdated
@JacobBarthelmeh

JacobBarthelmeh commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins, history unavailable.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10121

Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
Findings: 2
1 finding(s) posted as inline comments (see file-level comments below)

Info (1)

Stale docstring still says heap is Unused

File: wolfcrypt/src/wc_xmss.c:808
Function: wc_XmssKey_Init
Category: Dead/unreachable code

Doxygen comment for wc_XmssKey_Init still declares @param [in] heap Unused., but the function now stores key->heap = heap;. The (void) heap; was removed in this PR but the docstring was not updated.

* @param [in] heap   Unused.
 * @param [in] devId  Unused.

Recommendation: Update the docstring to describe heap as the dynamic memory hint used by subsequent allocations.


This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread wolfcrypt/src/wc_xmss.c
@JacobBarthelmeh

Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins

@JacobBarthelmeh JacobBarthelmeh removed their assignment May 1, 2026
@dgarske
dgarske merged commit 519c08a into wolfSSL:master May 5, 2026
415 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants