Fix initialization of SND_UNA to ISN#51
Merged
gasbytes merged 1 commit intowolfSSL:masterfrom Mar 2, 2026
Merged
Conversation
+ related test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TCP sender state initialization when accepting incoming connections so snd_una correctly starts at the connection’s ISN (preventing invalid sequence ordering), and adds a regression unit test.
Changes:
- Initialize
newts->sock.tcp.snd_unato the initial sequence number duringwolfIP_sock_accept(). - Add a unit test that validates
snd_unastarts at ISN and remains<= seqafter SYN-ACK advancesseq. - Register the new test in the unit test suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/wolfip.c |
Initializes snd_una on the accepted TCP socket to ensure correct ISN-based sender state. |
src/test/unit/unit.c |
Adds and registers a regression test covering snd_una initialization during accept(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gasbytes
approved these changes
Mar 2, 2026
Contributor
gasbytes
left a comment
There was a problem hiding this comment.
lgtm, confirmed fix locally via gh cli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfIP_sock_accept() was failing to set snd_una to the ISN
Fenrir/239