Use specific exception instead of bare except in build_ffi.py#116
Open
roberthdevries wants to merge 1 commit intowolfSSL:masterfrom
Open
Use specific exception instead of bare except in build_ffi.py#116roberthdevries wants to merge 1 commit intowolfSSL:masterfrom
roberthdevries wants to merge 1 commit intowolfSSL:masterfrom
Conversation
A bare except catches BaseException which includes KeyboardInterrupt, SystemExit, Exception, and others. Catching BaseException can make it hard to interrupt the program (e.g., with Ctrl-C) and can disguise other problems.
JeremiahM37
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare except catches BaseException which includes KeyboardInterrupt, SystemExit, Exception, and others.
Catching BaseException can make it hard to interrupt the program (e.g., with Ctrl-C) and can disguise other problems.