Skip to content

Convert python project configuration to pyproject.toml. #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roberthdevries wants to merge 2 commits into
base: master
Choose a base branch
from
+143 −27
Open

Convert python project configuration to pyproject.toml. #115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dbd495
Convert python project configuration to pyproject.toml.
roberthdevries Apr 9, 2026
3ae2756
Fix errors in pyproject.toml sections for ruff.
roberthdevries Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 133 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,133 @@
[project]
name = "wolfcrypt"
description = "Python module that encapsulates wolfSSL's crypto engine API."
readme = "README.rst"
requires-python = ">=3.10"
Copy link
Copy Markdown
Contributor

@JeremiahM37 JeremiahM37 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 [Medium] requires-python = ">=3.10" silently drops Python 3.6–3.9 support

The previous setup.py advertised support for Python 3.6, 3.7, 3.8, and 3.9 via classifiers (with no explicit python_requires). The new metadata bumps the floor to Python 3.10, which is a backward-incompatible change for downstream users still on 3.8/3.9 (still in widespread enterprise/distro use as of 2026). The PR description (Modern python projects standardize on pyproject.toml…) only mentions configuration consolidation, not a Python-version bump. If this is intentional it should be called out in the PR description and/or CHANGELOG; if not, restore the lower floor (e.g. >=3.8).

requires-python = ">=3.10"

Recommendation: Confirm the Python 3.10 floor is intentional and document the deprecation in the changelog; otherwise lower the floor back to the previously-supported version.

Copy link
Copy Markdown
Contributor Author

@roberthdevries roberthdevries Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional as older Python version are end-of-life. Ref: https://devguide.python.org/versions/

A note will be added to the Release Notes.

I tested with Python versions 3.10-3.15 that the software passes the unit tests which means that the statement above is actually true.

There is already one other patches (not merged) that adds something to the ChangeLog. Adding something now will create a merge conflict, as is true for some other patches as well. It would help a lot if these patches were merged on short notice, to help preventing this in the near future.

authors = [
{name = "wolfSSL Inc.", email="info@wolfssl.com"},
]
license = "GPL-2.0-only OR LicenseRef-WolfSSL"
license-files = ["LICENSING.rst"]
keywords = ["wolfssl", "wolfcrypt", "security", "cryptography"]
classifiers = [
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.10",
"Topic :: Security",
"Topic :: Security :: Cryptography",
"Topic :: Software Development"
]
dynamic = ["version"]
dependencies = [
"cffi>=1.0.0",
]

[project.urls]
Homepage = "https://github.com/wolfssl/wolfcrypt-py"

[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta:__legacy__"

[dependency-groups]
dev = [
"mypy",
"pytest",
"ruff",
"sphinx",
"sphinx-rtd-theme",
"tox >= 4",
"ty",
"types-cffi",
]

[tool.tox]
requires = ["tox>=4"]
env_list = ["py3"]

[tool.tox.env_run_base]
package = "wheel"
deps = ["-rrequirements/test.txt"]
commands = [["py.test", "tests/"]]


[tool.ruff]
# Exclude a variety of commonly ignored directories.
exclude = [
".bzr",
".direnv",
".eggs",
".git",
".git-rewrite",
".hg",
".idea",
".ipynb_checkpoints",
".mypy_cache",
".nox",
".pants.d",
".pyenv",
".pytest_cache",
".pytype",
".ruff_cache",
".svn",
".tox",
".venv",
".vscode",
"__pypackages__",
"_build",
"buck-out",
"build",
"dist",
"lib",
"node_modules",
"site-packages",
"venv",
]

# The GitHub editor is 127 characters wide.
line-length = 127
indent-width = 4

# Assume Python 3.10
target-version = "py310"

[lint]
# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`) codes by default.
# Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or
# McCabe complexity (`C901`) by default.
select = ["E4", "E7", "E9", "F", "B", "UP"]
ignore = ["UP031", "UP025", "UP032"]

# Allow fix for all enabled rules (when `--fix`) is provided.
fixable = ["ALL"]
unfixable = []

# Allow unused variables when underscore-prefixed.
dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"

[format]
# Like Black, use double quotes for strings.
quote-style = "double"

# Like Black, indent with spaces, rather than tabs.
indent-style = "space"

# Like Black, respect magic trailing commas.
skip-magic-trailing-comma = false

# Like Black, automatically detect the appropriate line ending.
line-ending = "auto"

# Enable auto-formatting of code examples in docstrings. Markdown,
# reStructuredText code/literal blocks and doctests are all supported.
#
# This is currently disabled by default, but it is planned for this
# to be opt-out in the future.
docstring-code-format = false

# Set the line length limit used when formatting code snippets in
# docstrings.
#
# This only has an effect when the `docstring-code-format` setting is
# enabled.
docstring-code-line-length = "dynamic"
Comment thread
roberthdevries marked this conversation as resolved.
Outdated
19 changes: 0 additions & 19 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,29 +55,10 @@
setup(
name="wolfcrypt",
version=verstr,
description="Python module that encapsulates wolfSSL's crypto engine API.",
long_description=long_description,
long_description_content_type='text/x-rst',
author="wolfSSL Inc.",
author_email="info@wolfssl.com",
url="https://github.com/wolfssl/wolfcrypt-py",
license="GPLv2 or Commercial License",

packages=find_packages(),
keywords="wolfssl, wolfcrypt, security, cryptography",
classifiers=[
u"License :: OSI Approved :: GNU General Public License v2 (GPLv2)",
u"License :: Other/Proprietary License",
u"Operating System :: OS Independent",
u"Programming Language :: Python :: 3",
u"Programming Language :: Python :: 3.6",
u"Programming Language :: Python :: 3.7",
u"Programming Language :: Python :: 3.8",
u"Programming Language :: Python :: 3.9",
u"Topic :: Security",
u"Topic :: Security :: Cryptography",
u"Topic :: Software Development"
],

setup_requires=["cffi>=1.0.0"],
install_requires=["cffi>=1.0.0"],
Expand Down
8 changes: 0 additions & 8 deletions tox.ini
View file
Open in desktop

This file was deleted.

Loading