Always check MqttDecode_Num's return code.#479
Merged
embhorn merged 2 commits intowolfSSL:masterfrom Apr 27, 2026
Merged
Conversation
kareem-wolfssl
requested review from
Copilot and
embhorn
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Improves MQTT-SN packet decoding robustness by consistently checking and acting on MqttDecode_Num() return codes during header/field parsing.
Changes:
- Capture
MqttDecode_Num()return values and return early on negative error codes across multiple MQTT-SN decode paths. - Use the decoded byte-count to advance payload pointers instead of assuming decode success.
- Add return-code handling for extended-length decoding during SN packet reads.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
embhorn
requested changes
Apr 3, 2026
Thanks to Weiheng Qiu for the report.
embhorn
reviewed
Apr 27, 2026
Member
embhorn
left a comment
embhorn
left a comment
There was a problem hiding this comment.
Skoll Code Review
Scan type: review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped
2 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Low] New buf_len pre-checks in SN_Decode_Header don't account for rx_buf advancement / long-header form —
src/mqtt_sn_packet.c:132-164 - [Info] Whitespace cleanup unrelated to the stated fix —
src/mqtt_sn_packet.c:1469
Review generated by Skoll
embhorn
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Weiheng Qiu for the report.