Add WOLFHSM_CFG_CANCEL_API for opt-in cancellation support#187
Merged
AlexLanzano merged 2 commits intowolfSSL:mainfrom Oct 2, 2025
Merged
Add WOLFHSM_CFG_CANCEL_API for opt-in cancellation support#187AlexLanzano merged 2 commits intowolfSSL:mainfrom
AlexLanzano merged 2 commits intowolfSSL:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an optional cancellation API feature through the WOLFHSM_CFG_CANCEL_API configuration flag. The changes revert previous broad gating and implement proper feature-specific guarding for cancellation functionality.
- Add
WOLFHSM_CFG_CANCEL_APIconfiguration flag to make cancellation support opt-in - Guard cancellation-related code, structures, and functions with the new configuration flag
- Replace broad
WOLFHSM_CFG_TEST_CLIENT_ONLY_TCPgating with more specificWOLFHSM_CFG_IS_TEST_SERVERguards for test instrumentation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfhsm/wh_settings.h | Adds documentation for the new WOLFHSM_CFG_CANCEL_API configuration flag |
| wolfhsm/wh_server.h | Guards server-side cancellation fields and functions with WOLFHSM_CFG_CANCEL_API |
| wolfhsm/wh_client.h | Guards client-side cancellation fields and functions with WOLFHSM_CFG_CANCEL_API |
| test/wh_test_crypto.c | Updates test code to use proper feature guards and temporarily disables server delay |
| src/wh_server_crypto.c | Guards cancellation handling in crypto operations with WOLFHSM_CFG_CANCEL_API |
| src/wh_server.c | Guards server cancellation functions and message handling with WOLFHSM_CFG_CANCEL_API |
| src/wh_client_crypto.c | Guards cancellable response handling with WOLFHSM_CFG_CANCEL_API |
| src/wh_client.c | Guards client cancellation functions with WOLFHSM_CFG_CANCEL_API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
25ddd34 to
19aec72
Compare
673e71c to
a139b4a
Compare
Refactor and fix cmac cancellation tests
94eb35f to
077066d
Compare
AlexLanzano
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #168 (review)