Reject unformatted PRs#176
Merged
billphipps merged 1 commit intowolfSSL:mainfrom Sep 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a GitHub Actions workflow that enforces code formatting on pull requests by checking if the diff against main is properly formatted using clang-format-15.
Key changes:
- Adds automated formatting validation for PRs
- Uses git-clang-format to check only modified files in the diff
- Provides clear instructions for developers to fix formatting issues locally
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bigbrett
force-pushed
the
clang-format-reject
branch
2 times, most recently
from
c559e74 to
efdc683
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bigbrett
force-pushed
the
clang-format-reject
branch
from
95b7ea5 to
f4b8191
Compare
bigbrett
force-pushed
the
clang-format-reject
branch
from
bbe6fcf to
f4b8191
Compare
jackctj117
pushed a commit
to jackctj117/wolfHSM
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GH action that enforces code formatting on a PR (only on the diff against the PR target branch, not on all files).
The action runs
git-clang-formatagainst the target branch (usuallymain) to see if there are any formatting changes that would be made (indicating the PR author didn't run the command locally). If there are changes, the action fails, prompting the PR author to rungit-clang-formatlocally and commit the changes.