Skip to content

Fix image len bound check in update_ram.c #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 2 commits into from
Mar 2, 2026
Merged

Fix image len bound check in update_ram.c #706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7b1002
Fix image len bound check in update_ram.c
danielinux Mar 2, 2026
00bf88b
Added upper limit for NO_PARTITIONS builds
danielinux Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/update_ram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ int wolfBoot_ramboot(struct wolfBoot_image *img, uint8_t *src, uint8_t *dst)

/* determine size of partition */
img_size = wolfBoot_image_size((uint8_t*)dst);
if (img_size > (WOLFBOOT_PARTITION_SIZE - IMAGE_HEADER_SIZE)) {
wolfBoot_printf("Invalid image size %u at %p\n", img_size, src);
return -1;
}

/* Read the entire image into RAM */
wolfBoot_printf("Loading image %d bytes from %p to %p...",
Expand Down
75 changes: 75 additions & 0 deletions tools/unit-tests/unit-update-ram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,69 @@ START_TEST (test_empty_panic)
END_TEST


START_TEST (test_ramboot_invalid_header)
{
struct wolfBoot_image img;
uint8_t bad_magic[4] = { 'G', 'O', 'L', 'F' };
int ret;

reset_mock_stats();
prepare_flash();
ext_flash_unlock();
ext_flash_write(WOLFBOOT_PARTITION_BOOT_ADDRESS, bad_magic, sizeof(bad_magic));
ext_flash_lock();

memset(&img, 0, sizeof(img));
ret = wolfBoot_ramboot(&img,
(uint8_t *)WOLFBOOT_PARTITION_BOOT_ADDRESS, wolfboot_ram);
ck_assert_int_eq(ret, -1);
cleanup_flash();
}
END_TEST

START_TEST (test_ramboot_oversize_rejected)
{
struct wolfBoot_image img;
uint32_t too_large = WOLFBOOT_PARTITION_SIZE;
int ret;

reset_mock_stats();
prepare_flash();
add_payload(PART_BOOT, 1, TEST_SIZE_SMALL);

ext_flash_unlock();
ext_flash_write(WOLFBOOT_PARTITION_BOOT_ADDRESS + 4,
(const uint8_t *)&too_large, 4);
ext_flash_lock();

memset(&img, 0, sizeof(img));
ret = wolfBoot_ramboot(&img,
(uint8_t *)WOLFBOOT_PARTITION_BOOT_ADDRESS, wolfboot_ram);
ck_assert_int_eq(ret, -1);
cleanup_flash();
}
END_TEST

START_TEST (test_ramboot_success)
{
struct wolfBoot_image img;
int ret;

reset_mock_stats();
prepare_flash();
add_payload(PART_BOOT, 1, TEST_SIZE_SMALL);

memset(&img, 0, sizeof(img));
ret = wolfBoot_ramboot(&img,
(uint8_t *)WOLFBOOT_PARTITION_BOOT_ADDRESS, wolfboot_ram);
ck_assert_int_eq(ret, 0);
ck_assert_int_eq(img.not_ext, 1);
ck_assert_int_eq(get_version_ramloaded(), 1);
cleanup_flash();
}
END_TEST


START_TEST (test_sunnyday_noupdate)
{
reset_mock_stats();
Expand Down Expand Up @@ -423,6 +486,9 @@ Suite *wolfboot_suite(void)

/* Test cases */
TCase *empty_panic = tcase_create("Empty partition panic test");
TCase *ramboot_invalid_header = tcase_create("Ramboot invalid header");
TCase *ramboot_oversize = tcase_create("Ramboot oversize");
TCase *ramboot_success = tcase_create("Ramboot success");
TCase *sunnyday_noupdate =
tcase_create("Sunny day test with no update available");
TCase *forward_update_samesize =
Expand All @@ -446,6 +512,9 @@ Suite *wolfboot_suite(void)


tcase_add_test(empty_panic, test_empty_panic);
tcase_add_test(ramboot_invalid_header, test_ramboot_invalid_header);
tcase_add_test(ramboot_oversize, test_ramboot_oversize_rejected);
tcase_add_test(ramboot_success, test_ramboot_success);
tcase_add_test(sunnyday_noupdate, test_sunnyday_noupdate);
tcase_add_test(forward_update_samesize, test_forward_update_samesize);
tcase_add_test(forward_update_tolarger, test_forward_update_tolarger);
Expand All @@ -463,6 +532,9 @@ Suite *wolfboot_suite(void)


suite_add_tcase(s, empty_panic);
suite_add_tcase(s, ramboot_invalid_header);
suite_add_tcase(s, ramboot_oversize);
suite_add_tcase(s, ramboot_success);
suite_add_tcase(s, sunnyday_noupdate);
suite_add_tcase(s, forward_update_samesize);
suite_add_tcase(s, forward_update_tolarger);
Expand All @@ -480,6 +552,9 @@ Suite *wolfboot_suite(void)

/* Set timeout for tests */
tcase_set_timeout(empty_panic, 5);
tcase_set_timeout(ramboot_invalid_header, 5);
tcase_set_timeout(ramboot_oversize, 5);
tcase_set_timeout(ramboot_success, 5);
tcase_set_timeout(sunnyday_noupdate, 5);
tcase_set_timeout(forward_update_samesize, 5);
tcase_set_timeout(forward_update_tolarger, 5);
Expand Down
Loading