So, I think this is a minimal solution to this GtkWebkit WebView navigation problem - #660
Merged
Merged
Conversation
navigation problem. Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
Signed-off-by: Hans Dijkema <hans@dijkewijk.nl>
AlbertShown
approved these changes
Oct 22, 2025
Member
|
That's sounds perfect 👍 |
Contributor
Author
Thank you for letting me contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By debugging I learned that the webView structure is initially not created.
Only further on in the process there will be a webView structure that can be checked for.
Hence the statement at line 12140 was only necessary, because before that there was no webView structure to set variable
in_showto true.Because of this I moved the
in_showattribute to the_webui_window_t. That will always be there. Only when on linux though.Now the only place to set in_show to true is at the beginning of
_webui_show_window, before all other processing begins.